Skip to content

Name rustbuild instead of saying 'the bootstrap binary' #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Jul 22, 2020

r? @Mark-Simulacrum - is this reasonable? It's consistent with the A-rustbuild tag on rust-lang/rust.

@jyn514
Copy link
Member Author

jyn514 commented Jul 22, 2020

Separated out from #807

@Mark-Simulacrum
Copy link
Member

I think we should wait to land this until we've renamed it upstream.

@jyn514 jyn514 added the S-blocked Status: this PR is blocked waiting for something label Jul 24, 2020
@mark-i-m
Copy link
Member

mark-i-m commented Aug 2, 2020

Is there a particular PR on rust-lang/rust that this is blocked on?

@jyn514
Copy link
Member Author

jyn514 commented Aug 2, 2020

Not that I'm aware of.

@Mark-Simulacrum are you sure it makes sense to rename the whole directory? In my mind 'rustbuild' is just the rust portion while 'bootstrap' is both python and rust put together.

@Mark-Simulacrum
Copy link
Member

I've never separated the two, personally, but I also don't care much either way.

@mark-i-m
Copy link
Member

mark-i-m commented Oct 4, 2020

What's the status of this?

@jyn514
Copy link
Member Author

jyn514 commented Oct 4, 2020

I don't think this is a useful change; there's no point in adding new terminology if it's not going to be used consistently.

@jyn514 jyn514 closed this Oct 4, 2020
@jyn514 jyn514 deleted the rustbuild branch January 29, 2021 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-blocked Status: this PR is blocked waiting for something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants