Skip to content

Fixes menu for rustdoc page #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 18, 2020
Merged

Fixes menu for rustdoc page #804

merged 4 commits into from
Jul 18, 2020

Conversation

FedericoPonzi
Copy link
Contributor

No description provided.

src/SUMMARY.md Outdated
@@ -14,7 +14,7 @@
- [Bootstrapping](./building/bootstrapping.md)
- [Distribution artifacts](./building/build-install-distribution-artifacts.md)
- [Documenting Compiler](./building/compiler-documenting.md)
- [Rustdoc](./rustdoc.md)
- [Rustdoc](./building/rustdoc.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, the problem here is that "The Rustc Driver and Interface" has also the rustdoc chapter, not the path.
It's introduced by 093b903 but I assume it isn't intentional (cc @mark-i-m). I think it's a better way just to remove that entry, not to change the path.

@FedericoPonzi
Copy link
Contributor Author

mdbook build working locally, CI is failed because of lots of 429:

    │                     ^ Server returned 429 Too Many Requests for https://github.com/servo/homu

Can someone plesae restart travis? Thanks!

@JohnTitor
Copy link
Member

@FedericoPonzi
Copy link
Contributor Author

ugh, sorry for the misunderstanding! I've just pushed the required changes, let me know if it's ok now!

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for contributing @FedericoPonzi!

@JohnTitor JohnTitor merged commit 6353694 into rust-lang:master Jul 18, 2020
@FedericoPonzi FedericoPonzi deleted the summary-fix branch July 18, 2020 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants