-
Notifications
You must be signed in to change notification settings - Fork 543
Add some guidelines on the CLI. #717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
# Command-line Arguments | ||
|
||
Command-line flags are documented in the [rustc book][cli-docs]. All *stable* | ||
flags should be documented there. Unstable flags should be documented in the | ||
[unstable book]. | ||
|
||
## Guidelines | ||
|
||
- Flags should be orthogonal to each other. For example, if we'd have a | ||
json-emitting variant of multiple actions `foo` and `bar`, an additional | ||
`--json` flag is better than adding `--foo-json` and `--bar-json`. | ||
- Avoid flags with the `no-` prefix. Instead, use the [`parse_bool`] function, | ||
such as `-C embed-bitcode=no`. | ||
- Consider the behavior if the flag is passed multiple times. In some | ||
situations, the values should be accumulated (in order!). In other | ||
situations, subsequence flags should override previous flags (for example, | ||
ehuss marked this conversation as resolved.
Show resolved
Hide resolved
|
||
the lint-level flags). And some flags (like `-o`) should generate an error | ||
if it is too ambiguous what multiple flags would mean. | ||
- Always give options a long descriptive name, if only for more understandable | ||
compiler scripts. | ||
- The `--verbose` flag is for adding verbose information to `rustc` output | ||
when not compiling a program. For example, using it with the `--version` | ||
flag gives information about the hashes of the code. | ||
ehuss marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- Experimental flags and options must be guarded behind the `-Z | ||
unstable-options` flag. | ||
|
||
[cli-docs]: https://doc.rust-lang.org/rustc/command-line-arguments.html | ||
[unstable book]: https://doc.rust-lang.org/nightly/unstable-book/ | ||
[`parse_bool`]: https://github.com/rust-lang/rust/blob/e5335592e78354e33d798d20c04bcd677c1df62d/src/librustc_session/options.rs#L307-L313 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest moving this to the top of Part 3, next to the rustc-driver chapter.