how to build and run compiler, first shot #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
reviewed
Jan 24, 2018
src/how-to-build-and-run.md
Outdated
| Then you will want to open up the file and change the following | ||
| settings (and possibly others, such as `llvm.ccache`): | ||
|
|
||
| ``` |
src/how-to-build-and-run.md
Outdated
| probably the best "go to" command for building a local rust: | ||
|
|
||
| ``` | ||
| ./x.py build --incremental --stage 1 src/libstd |
There was a problem hiding this comment.
I would use the short form -i instead of --incremental here 😄
spastorino
reviewed
Jan 24, 2018
src/how-to-build-and-run.md
Outdated
|
|
||
| - Build stage1 rustc with stage0 compiler | ||
| - Build libstd with stage1 compiler (up to here is the same) | ||
| - Build stage2 rustc with stage1 compiler (this part is new) |
There was a problem hiding this comment.
Maybe explain what is stage2? previously you did explain stage1.
spastorino
reviewed
Jan 24, 2018
src/how-to-build-and-run.md
Outdated
| resulting rustc, we recommend creating rustup toolchains. The first | ||
| one will run the stage1 compiler (which we built above). The second | ||
| will execute the stage2 compiler (which we did not build, but which | ||
| you will likely build at some point). |
There was a problem hiding this comment.
why you will likely build it?. Maybe explain that 😄
|
OK, fixed a few nits, gonna land. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8