rewrite bootstrapping stages #1650
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* make date-check lightweight This avoids having to write the date twice when updating date-check. Before "As of <-- 2022-07 --> July 2022" After "As of July 2022" * please clippy * update date-check docs * accept review suggestion Co-authored-by: Noah Lev <[email protected]> * address review comment rust-lang#1394 (review) * accept review suggestion Co-authored-by: Noah Lev <[email protected]> * address review comment rust-lang#1394 (review) * address review comment rust-lang#1394 (comment) * this breaks markdown * address review comment rust-lang#1394 (comment) This led to a more robust regex, though making the tool more picky. It also found a wrong date format that was missed. * address review comment rust-lang#1394 (comment) * address review comment rust-lang#1394 (comment) * accept review suggestion This was reverted by mistake Co-authored-by: Noah Lev <[email protected]> * address review comment rust-lang#1394 (comment) * use a more simple fn * address review comment rust-lang#1394 (comment) Much more clean * nit * accept review suggestion Co-authored-by: Noah Lev <[email protected]> * avoid a failed regex Also, test new shape * adjust to new regex (which uses named groups) New regex was introduced by 456008c Co-authored-by: Noah Lev <[email protected]>
This diagram is based on the diagram in Joshua Nelson's talk on bootstrapping at RustConf 2022 [1]. I converted it to Mermaid and made some tweaks to simplify it and bring it closer to bootstrap's terminology, and then Ralf Jung added nodes for copying artifacts. [1]: https://rustconf.com/schedule#bootstrapping-the-once-and-future-compiler Co-authored-by: Joshua Nelson <[email protected]> Co-authored-by: Ralf Jung <[email protected]>
Co-authored-by: Noah Lev <[email protected]>
Also, make link to upstream llvm repo clickable
* fix incorrect #[note] syntax * more syntax fixes * add missing lifetime
One could not run it like the following, for the would be a panic:
cargo run --manifest-path ci/date-check/Cargo.toml .
Also, remove the need to specify argument, in which case, current_dir
is assumed.
Signed-off-by: Yuki Okushi <[email protected]>
This file was moved in rust-lang/rust#108618
Co-authored-by: Yuki Okushi <[email protected]>
JohnTitor
added
the
S-waiting-on-review
|
Sorry, due to me messing up a git operation, we sadly had to force-push the whole commit history of rustc-dev-guide :( If you'd like to update this pull request, you will have to rebase it in a special way onto the new commit history (the new More context can be found here. |
|
Thanks for the PR, unfortunately we'll be making some substantial changes to the staging logic in rust-lang/rust#119899, so I'm closing this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following from #1458.
This may be too much to review.
So I will extract smaller pull requests from it and rebase as they are merged.
The first of them, #1555, is already merged (thank you!).
This will remain a draft until it is small enough to be reviewed.