Skip to content

updating-llvm: keep a calm tone #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2022
Merged

updating-llvm: keep a calm tone #1449

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bef89e3
updating-llvm: keep a calm tone
tshepang Aug 27, 2022
488fccb
accept review suggestion
tshepang Nov 20, 2022
f965b67
address review comment
tshepang Nov 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 9 additions & 14 deletions src/backend/updating-llvm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,15 @@

<!-- toc -->

The Rust compiler uses LLVM as its primary codegen backend today, and naturally
we want to at least occasionally update this dependency! Currently we do not
have a strict policy about when to update LLVM or what it can be updated to, but
a few guidelines are applied:

* We try to always support the latest released version of LLVM
* We try to support the "last few" versions of LLVM (how many is changing over
time)
* We allow moving to arbitrary commits during development.
* Strongly prefer to upstream all patches to LLVM before including them in
rustc.

This policy may change over time (or may actually start to exist as a formal
policy!), but for now these are rough guidelines!
Comment on lines -17 to -18
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove this sentence? This caution looks useful to me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's basically repeated, so I keep it in one place... see line 6 of new changes.

<!-- date-check: Aug 2022 -->
There is no formal policy about when to update LLVM or what it can be updated to,
but a few guidelines are applied:

* We try to always support the latest released version
* We try to support the last few versions of LLVM
(and the number changes over time)
Copy link
Member

@JohnTitor JohnTitor Aug 31, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The former removed "of LLVM" whereas the latter keeps it, it's inconsistent (I mean, we don't have to remove the "of LLVM").

* We allow moving to arbitrary commits during development
* We strongly prefer to upstream all patches to LLVM before including them in rustc

## Why update LLVM?

Expand Down