Skip to content

Fix some more links #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Fix some more links #1260

merged 1 commit into from
Nov 24, 2021

Conversation

JohnTitor
Copy link
Member

Separating from #1259 because I'm not 100% sure if compute_hir_hash is the right link.
cc @cjgillot could you review this?

@JohnTitor JohnTitor changed the title Fix some links Fix some more links Nov 15, 2021
@camelid camelid self-assigned this Nov 17, 2021
@@ -56,7 +56,7 @@ because one must first build the new compiler with an older compiler
and then use that to build the new compiler with itself.
For development, you usually only want the `stage1` compiler,
which you can build with `./x.py build library/std`.
See [Building the Compiler](/building/how-to-build-and-run.html#building-the-compiler).
See [Building the Compiler](./how-to-build-and-run.html#building-the-compiler).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-existing, but while you're at it:

Suggested change
See [Building the Compiler](./how-to-build-and-run.html#building-the-compiler).
See [Building the Compiler](./how-to-build-and-run.md#building-the-compiler).

Copy link
Member

@camelid camelid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me on the non-crate-hash changes. Let's wait for @cjgillot for the crate hash change though.

@camelid camelid assigned cjgillot and unassigned camelid Nov 17, 2021
@camelid camelid added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Nov 17, 2021
@jyn514
Copy link
Member

jyn514 commented Nov 24, 2021

@camelid I think we should merge this in the meantime and we can change the link later if necessary.

@jyn514 jyn514 merged commit c4776cb into rust-lang:master Nov 24, 2021
@JohnTitor JohnTitor deleted the fix-links-part-1 branch November 24, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants