Skip to content

Update docs from date triage for 2021-02 #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 21, 2021

Conversation

camelid
Copy link
Member

@camelid camelid commented Feb 4, 2021

Closes #1046.

The biggest change was updating the list of rustdoc passes. Several new
ones have been added since that documentation was written, so I added
those, and I also sorted the list so it is roughly alphabetical (except
for the part for the strip-* passes, which I left in the same order
since one of the list items has two passes so there's no "correct"
order).

The biggest change was updating the list of rustdoc passes. Several new
ones have been added since that documentation was written, so I added
those, and I also sorted the list so it is roughly alphabetical (except
for the part for the `strip-*` passes, which I left in the same order
since one of the list items has two passes so there's no "correct"
order).
@camelid camelid added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Feb 4, 2021
@camelid
Copy link
Member Author

camelid commented Feb 4, 2021

I asked people in the compiler team and rustdoc team streams on Zulip if they could take a look at the parts I'm unsure about.

@camelid
Copy link
Member Author

camelid commented Feb 16, 2021

Okay, I updated the PR. This is what's left to resolve:

@camelid camelid marked this pull request as ready for review February 16, 2021 06:09
@camelid
Copy link
Member Author

camelid commented Feb 21, 2021

I think this should be blocked on #1066 since it will likely have conflicts.

Didn't get a response on Zulip, so saving this for another time.
@camelid
Copy link
Member Author

camelid commented Feb 21, 2021

Should be ready for final review! (February's almost over too.)

@camelid camelid added the S-blocked Status: this PR is blocked waiting for something label Feb 21, 2021
@igaray
Copy link
Member

igaray commented Feb 21, 2021

Seeing this process for the first time, even though I thought it was a good idea when it was implemented, now I really see it working. This PR and its comments are a good reference for the future.

@camelid camelid removed the S-blocked Status: this PR is blocked waiting for something label Feb 21, 2021
@camelid camelid merged commit c4c0f33 into rust-lang:master Feb 21, 2021
@camelid camelid deleted the date-triage-2021-02 branch February 21, 2021 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date Reference Triage for 2021-02
4 participants