Skip to content

Link to feature_err in stability section #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2021
Merged

Link to feature_err in stability section #1022

merged 1 commit into from
Jan 19, 2021

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Jan 14, 2021

I want to link to an example PR before merging this, but putting this up just so I won't forget about it.

@jyn514 jyn514 added the S-waiting-on-author Status: this PR is waiting for additional action by the OP label Jan 14, 2021
@jyn514
Copy link
Member Author

jyn514 commented Jan 14, 2021

I want to link to an example PR before merging this

Done.

@jyn514 jyn514 added S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content and removed S-waiting-on-author Status: this PR is waiting for additional action by the OP labels Jan 14, 2021
@camelid
Copy link
Member

camelid commented Jan 15, 2021

This seems right to me, but maybe we should have someone familiar with rustc_session::parse::feature_err review briefly as well? It might not be worth it, but wanted to suggest that :)

@camelid
Copy link
Member

camelid commented Jan 15, 2021

lcnr and Nadrieril seemed to give the thumbs-up on the Zulip thread, so maybe that's good enough :)

camelid
camelid approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@camelid camelid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since lcnr and Nadrieril gave a thumbs-up on Zulip and we just merged a change
to rustdoc that uses this function, I think this is good to merge :)

@camelid camelid merged commit bd8e94a into rust-lang:master Jan 19, 2021
@jyn514 jyn514 deleted the features branch January 19, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camelid camelid camelid approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jyn514 @camelid