Skip to content

CI using old cache of mdbook #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ehuss opened this issue Feb 17, 2018 · 2 comments
Closed

CI using old cache of mdbook #58

ehuss opened this issue Feb 17, 2018 · 2 comments

Comments

@ehuss
Copy link
Contributor

ehuss commented Feb 17, 2018

I'm not 100% certain without access to the Travis cache, but I believe that it is using an old version of mdbook (0.0.28) from the cache. This was noticed because Travis is not running mdbook-linkcheck, and the output in the Travis logs looks like the old version.

In the Travis logs, it looks like PRs are picking up this old cache from the master branch:

fetching master/cache-linux-trusty-e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855--cargo-stable.tgz
found cache

Due to the way ci/install.sh is written, it will skip if mdbook is already installed, but it does not check which version is already installed.

A quick short-term solution is to delete the travis caches.

I can make a PR to change the install.sh script to force a reinstall if there is a version mismatch. Alternatively, you can just manually delete the travis caches whenever you upgrade mdbook.

@mark-i-m
Copy link
Member

I can make a PR to change the install.sh script to force a reinstall if there is a version mismatch.

Thanks @ehuss ! I would appreciate that :)

It explains #47 (comment)

@mark-i-m
Copy link
Member

I just dropped the caches, and will restart the travis builds for outstanding PRs, but a permanent fix would be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants