Skip to content

Windows prerequisite instructions install incorrect Python package #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Mar 4, 2022 · 7 comments · Fixed by #1328
Closed

Windows prerequisite instructions install incorrect Python package #1324

ghost opened this issue Mar 4, 2022 · 7 comments · Fixed by #1328
Labels
E-easy Difficulty: might be a good place for a beginner E-help-wanted Call for participation: extra help is wanted

Comments

@ghost
Copy link

ghost commented Mar 4, 2022

I'm working on contributing to rust for the first time and was following the instructions here: https://rustc-dev-guide.rust-lang.org/building/prerequisites.html

This says to use "winget install python", but this will install "Introduction to Python Programming by GoLearningBus". I think the correct instruction should be "winget install Python.Python.3".

I assume this got messed up when the msstore source was added, and winget is now just picking an arbitrary python package. In light of that, it might be appropriate to change the cmake instruction to "winget install Kitware.CMake" as well.

@camelid
Copy link
Member

camelid commented Mar 5, 2022

cc @wesleywiser – I think you're knowledgeable about Rust and Windows?

@wesleywiser
Copy link
Member

Yeah, changing the instructions to use the complete package names (Python.Python.3 and Kitware.CMake) is the correct solution. 👍

@ghost
Copy link
Author

ghost commented Mar 8, 2022

Actually, I wonder if a -e (for --exact) should be thrown in there too, just to be extra sure. :)

winget install -e Python.Python.3
winget install -e Kitware.CMake

@JohnTitor JohnTitor added the E-easy Difficulty: might be a good place for a beginner label Mar 9, 2022
@camelid camelid added the E-help-wanted Call for participation: extra help is wanted label Mar 12, 2022
@camelid
Copy link
Member

camelid commented Mar 12, 2022

Can someone familiar with Windows open a PR to fix this? @skippy10110 would you like to?

@ghost
Copy link
Author

ghost commented Mar 12, 2022

I can do that up. I was distracted working on my first ever MCP and so I was being lazy not posting a PR myself. 🤣 I did end up just switching over to linux for dev since it seemed easier. (WSL rocks!)

@ghost
Copy link
Author

ghost commented Mar 12, 2022

I just posted a PR, but this is actually my first time doing that on GitHub. Let me know if I did anything wrong!

@camelid
Copy link
Member

camelid commented Mar 12, 2022

You did it correctly :)

camelid pushed a commit that referenced this issue Mar 14, 2022
…alled (-e for --exact, and full package names to ensure arbitrary packages from the msstore source aren't installed)

fixes #1324
Kobzol pushed a commit to Kobzol/rustc-dev-guide that referenced this issue Jan 3, 2025
…alled (-e for --exact, and full package names to ensure arbitrary packages from the msstore source aren't installed)

fixes rust-lang#1324
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-easy Difficulty: might be a good place for a beginner E-help-wanted Call for participation: extra help is wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants