-
Notifications
You must be signed in to change notification settings - Fork 543
Windows prerequisite instructions install incorrect Python package #1324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
cc @wesleywiser – I think you're knowledgeable about Rust and Windows? |
Yeah, changing the instructions to use the complete package names ( |
Actually, I wonder if a -e (for --exact) should be thrown in there too, just to be extra sure. :)
|
Can someone familiar with Windows open a PR to fix this? @skippy10110 would you like to? |
I can do that up. I was distracted working on my first ever MCP and so I was being lazy not posting a PR myself. 🤣 I did end up just switching over to linux for dev since it seemed easier. (WSL rocks!) |
I just posted a PR, but this is actually my first time doing that on GitHub. Let me know if I did anything wrong! |
You did it correctly :) |
…alled (-e for --exact, and full package names to ensure arbitrary packages from the msstore source aren't installed) fixes #1324
…alled (-e for --exact, and full package names to ensure arbitrary packages from the msstore source aren't installed) fixes rust-lang#1324
I'm working on contributing to rust for the first time and was following the instructions here: https://rustc-dev-guide.rust-lang.org/building/prerequisites.html
This says to use "winget install python", but this will install "Introduction to Python Programming by GoLearningBus". I think the correct instruction should be "winget install Python.Python.3".
I assume this got messed up when the msstore source was added, and winget is now just picking an arbitrary python package. In light of that, it might be appropriate to change the cmake instruction to "winget install Kitware.CMake" as well.
The text was updated successfully, but these errors were encountered: