Simplify implementation for par_for_each_module

[cjgillot]

No description provided.

[rust-highfive]

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

[cjgillot]

Re-rolling the dice.
r? compiler

[compiler-errors]

I wonder what the perf implication of those #[inline] is.

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[compiler-errors]

r=me when perf comes back regardless

[bors]

⌛ Trying commit 4c5ec30 with merge 1c692bbc3244d70a8f720cb486f0e89547aa99d0...

[bors]

☀️ Try build successful - checks-actions
Build commit: 1c692bbc3244d70a8f720cb486f0e89547aa99d0 (1c692bbc3244d70a8f720cb486f0e89547aa99d0)

[rust-timer]

Queued 1c692bbc3244d70a8f720cb486f0e89547aa99d0 with parent 0b71ffc, future comparison URL.

[rust-timer]

Finished benchmarking commit (1c692bbc3244d70a8f720cb486f0e89547aa99d0): comparison url.

Instruction count

• Primary benchmarks: ❌ relevant regression found
• Secondary benchmarks: no relevant changes found

	mean1	max	count2
Regressions ❌ (primary)	1.0%	1.0%	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.0%	1.0%	1

Max RSS (memory usage)

Results

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: mixed results

	mean1	max	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.8%	2.8%	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.5%	-2.0%	3
All ❌✅ (primary)	-	-	0

Cycles

Results

• Primary benchmarks: ❌ relevant regression found
• Secondary benchmarks: ❌ relevant regression found

	mean1	max	count2
Regressions ❌ (primary)	2.1%	2.1%	1
Regressions ❌ (secondary)	4.8%	4.8%	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.1%	2.1%	1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩² ↩³

2. number of relevant changes ↩ ↩² ↩³

[compiler-errors]

That perf regression is noise I think. I've seen webrender getting +/- 1% perf changes on so many PRs. Posted about it on zulip. r=me regardless unless you think the regressions is actually real.

[cjgillot]

@bors r=compiler-errors

[bors]

📌 Commit 4c5ec30 has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

⌛ Testing commit 4c5ec30 with merge 8818b00...

[bors]

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 8818b00 to master...

[rust-timer]

Finished benchmarking commit (8818b00): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.9%	[1.9%, 1.9%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.1%	[-2.1%, -2.1%]	2
All ❌✅ (primary)	-	-	0

Footnotes

1. the arithmetic mean of the percent change ↩ ↩²

2. number of relevant changes ↩ ↩²