Skip to content

optimize insert_range method of IntervalSet #96895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2022
Merged

Conversation

SparrowLii
Copy link
Member

This PR fixes the FIXME in the insert_range method that avoids recurse calculations when overlaping

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 10, 2022
@rust-highfive
Copy link
Contributor

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 10, 2022
@Kobzol
Copy link
Contributor

Kobzol commented May 10, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 10, 2022
@bors
Copy link
Collaborator

bors commented May 10, 2022

⌛ Trying commit eead168 with merge 825c36f2ab4c1153d524f996c36af6a2e752278e...

@bors
Copy link
Collaborator

bors commented May 10, 2022

☀️ Try build successful - checks-actions
Build commit: 825c36f2ab4c1153d524f996c36af6a2e752278e (825c36f2ab4c1153d524f996c36af6a2e752278e)

@rust-timer
Copy link
Collaborator

Queued 825c36f2ab4c1153d524f996c36af6a2e752278e with parent d53f1e8, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (825c36f2ab4c1153d524f996c36af6a2e752278e): comparison url.

Summary:

  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: 🎉 relevant improvements found
Regressions 😿
(primary)
Regressions 😿
(secondary)
Improvements 🎉
(primary)
Improvements 🎉
(secondary)
All 😿 🎉
(primary)
count1 0 0 3 6 3
mean2 N/A N/A -0.2% -1.3% -0.2%
max N/A N/A -0.2% -2.3% -0.2%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. number of relevant changes

  2. the arithmetic mean of the percent change

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 10, 2022
@lqd
Copy link
Member

lqd commented May 10, 2022

as the original author of the IntervalSet: cc @Mark-Simulacrum

@Mark-Simulacrum Mark-Simulacrum self-assigned this May 10, 2022
@davidtwco davidtwco removed their assignment May 12, 2022
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented May 15, 2022

📌 Commit eead168 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 15, 2022
@bors
Copy link
Collaborator

bors commented May 15, 2022

⌛ Testing commit eead168 with merge 0f202d2...

@bors
Copy link
Collaborator

bors commented May 15, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 0f202d2 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 15, 2022
@bors bors merged commit 0f202d2 into rust-lang:master May 15, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 15, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0f202d2): comparison url.

Summary:

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvements found
Regressions 😿
(primary)
Regressions 😿
(secondary)
Improvements 🎉
(primary)
Improvements 🎉
(secondary)
All 😿 🎉
(primary)
count1 0 0 0 6 0
mean2 N/A N/A N/A -1.3% N/A
max N/A N/A N/A -2.4% N/A

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. number of relevant changes

  2. the arithmetic mean of the percent change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants