-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Quick fix for #96223. #96679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Quick fix for #96223. #96679
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
// Test case for #96223. | ||
// An ICE was triggered because of a failed assertion. | ||
// Thanks to @Manishearth for the minimal test case. | ||
ricked-twice marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
pub trait Foo<'de>: Sized {} | ||
|
||
pub trait Bar<'a>: 'static { | ||
type Inner: 'a; | ||
} | ||
|
||
pub trait Fubar { | ||
type Bar: for<'a> Bar<'a>; | ||
} | ||
|
||
pub struct Baz<T>(pub T); | ||
|
||
impl<'de, T> Foo<'de> for Baz<T> where T: Foo<'de> {} | ||
|
||
struct Empty; | ||
|
||
impl<M> Dummy<M> for Empty | ||
where | ||
M: Fubar, | ||
for<'de> Baz<<M::Bar as Bar<'de>>::Inner>: Foo<'de>, | ||
{ | ||
} | ||
|
||
pub trait Dummy<M> | ||
where | ||
M: Fubar, | ||
{ | ||
} | ||
|
||
pub struct EmptyBis<'a>(&'a [u8]); | ||
|
||
impl<'a> Bar<'a> for EmptyBis<'static> { | ||
type Inner = EmptyBis<'a>; | ||
} | ||
|
||
pub struct EmptyMarker; | ||
|
||
impl Fubar for EmptyMarker { | ||
type Bar = EmptyBis<'static>; | ||
} | ||
|
||
fn icey_bounds<D: Dummy<EmptyMarker>>(p: &D) {} | ||
|
||
fn trigger_ice() { | ||
let p = Empty; | ||
icey_bounds(&p); //~ERROR | ||
ricked-twice marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
|
||
fn main() {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
error[E0277]: the trait bound `for<'de> EmptyBis<'de>: Foo<'_>` is not satisfied | ||
--> $DIR/issue-96223.rs:50:17 | ||
| | ||
LL | icey_bounds(&p); | ||
| ----------- ^^ the trait `for<'de> Foo<'_>` is not implemented for `EmptyBis<'de>` | ||
| | | ||
| required by a bound introduced by this call | ||
| | ||
= help: the trait `Foo<'de>` is implemented for `Baz<T>` | ||
note: required because of the requirements on the impl of `for<'de> Foo<'de>` for `Baz<EmptyBis<'de>>` | ||
--> $DIR/issue-96223.rs:17:14 | ||
| | ||
LL | impl<'de, T> Foo<'de> for Baz<T> where T: Foo<'de> {} | ||
| ^^^^^^^^ ^^^^^^ | ||
note: required because of the requirements on the impl of `Dummy<EmptyMarker>` for `Empty` | ||
--> $DIR/issue-96223.rs:21:9 | ||
| | ||
LL | impl<M> Dummy<M> for Empty | ||
| ^^^^^^^^ ^^^^^ | ||
note: required by a bound in `icey_bounds` | ||
--> $DIR/issue-96223.rs:46:19 | ||
| | ||
LL | fn icey_bounds<D: Dummy<EmptyMarker>>(p: &D) {} | ||
| ^^^^^^^^^^^^^^^^^^ required by this bound in `icey_bounds` | ||
|
||
error: aborting due to previous error | ||
|
||
For more information about this error, try `rustc --explain E0277`. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.