-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Do not use LEB128 for encoding u16 and i16 #92314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit b11dc2108beb5dda9b6249d76fae83bfeb8f5249 with merge 12ca1781010a9ea74d60a1feba203098b7102bd9... |
☀️ Try build successful - checks-actions |
Queued 12ca1781010a9ea74d60a1feba203098b7102bd9 with parent f8abed9, future comparison URL. |
Finished benchmarking commit (12ca1781010a9ea74d60a1feba203098b7102bd9): comparison url. Summary: This change led to moderate relevant improvements 🎉 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
Looks like artifact sizes increased a bit, though not much, as expected. E.g. https://perf.rust-lang.org/detailed-query.html?commit=12ca1781010a9ea74d60a1feba203098b7102bd9&base_commit=f8abed9ed48bace6be0087bcd44ed534e239b8d8&benchmark=ripgrep-check&scenario=incr-unchanged |
b11dc21
to
6c9ffe4
Compare
I refactored the code to remove |
📌 Commit 6c9ffe4 has been approved by |
⌛ Testing commit 6c9ffe4 with merge 8618053cebad3af83f6ef781d14db198c5e053a7... |
💔 Test failed - checks-actions |
@bors retry |
☀️ Test successful - checks-actions |
Finished benchmarking commit (399ba6b): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
An experiment to try out the suggestion from #68779.
Closes: #68779