Skip to content

Do not use LEB128 for encoding u16 and i16 #92314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Dec 27, 2021

An experiment to try out the suggestion from #68779.

Closes: #68779

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 27, 2021
@rust-highfive
Copy link
Contributor

r? @michaelwoerister

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 27, 2021
@rust-log-analyzer

This comment has been minimized.

@camelid
Copy link
Member

camelid commented Dec 27, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 27, 2021
@bors
Copy link
Collaborator

bors commented Dec 27, 2021

⌛ Trying commit b11dc2108beb5dda9b6249d76fae83bfeb8f5249 with merge 12ca1781010a9ea74d60a1feba203098b7102bd9...

@bors
Copy link
Collaborator

bors commented Dec 27, 2021

☀️ Try build successful - checks-actions
Build commit: 12ca1781010a9ea74d60a1feba203098b7102bd9 (12ca1781010a9ea74d60a1feba203098b7102bd9)

@rust-timer
Copy link
Collaborator

Queued 12ca1781010a9ea74d60a1feba203098b7102bd9 with parent f8abed9, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (12ca1781010a9ea74d60a1feba203098b7102bd9): comparison url.

Summary: This change led to moderate relevant improvements 🎉 in compiler performance.

  • Moderate improvement in instruction counts (up to -2.1% on incr-unchanged builds of helloworld)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 28, 2021
@camelid
Copy link
Member

camelid commented Dec 28, 2021

@Kobzol Kobzol force-pushed the encoding-u16-leb128 branch from b11dc21 to 6c9ffe4 Compare December 28, 2021 08:29
@Kobzol
Copy link
Contributor Author

Kobzol commented Dec 28, 2021

I refactored the code to remove unsafe.

@michaelwoerister
Copy link
Member

Looks good to me, thanks @Kobzol!

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 3, 2022

📌 Commit 6c9ffe4 has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2022
@bors
Copy link
Collaborator

bors commented Jan 3, 2022

⌛ Testing commit 6c9ffe4 with merge 8618053cebad3af83f6ef781d14db198c5e053a7...

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Collaborator

bors commented Jan 3, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 3, 2022
@Aaron1011
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2022
@bors
Copy link
Collaborator

bors commented Jan 3, 2022

⌛ Testing commit 6c9ffe4 with merge 399ba6b...

@bors
Copy link
Collaborator

bors commented Jan 3, 2022

☀️ Test successful - checks-actions
Approved by: michaelwoerister
Pushing 399ba6b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 3, 2022
@bors bors merged commit 399ba6b into rust-lang:master Jan 3, 2022
@rustbot rustbot added this to the 1.59.0 milestone Jan 3, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (399ba6b): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why does rustc_serialize use uleb128 to encode all integers?
9 participants