Skip to content

Fix stack overflow in usefulness.rs #91164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

Badel2
Copy link
Contributor

@Badel2 Badel2 commented Nov 23, 2021

Fix #88747

Applied the suggestion from @nbdd0121, not sure if this has any drawbacks. The first call to ensure_sufficient_stack is not needed to fix the test case, but I added it to be safe.

@rust-highfive
Copy link
Contributor

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 23, 2021
@camelid camelid added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Nov 25, 2021
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 26, 2021

📌 Commit 6955afe has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2021
@bors
Copy link
Collaborator

bors commented Nov 26, 2021

⌛ Testing commit 6955afe with merge 454cc5f...

@bors
Copy link
Collaborator

bors commented Nov 26, 2021

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing 454cc5f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 26, 2021
@bors bors merged commit 454cc5f into rust-lang:master Nov 26, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 26, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (454cc5f): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stack overflow / segfault in rustc when using a pattern for (very) large tuple
7 participants