Skip to content

Add inflate to pgo #86697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Add inflate to pgo #86697

merged 1 commit into from
Jun 29, 2021

Conversation

jackh726
Copy link
Member

@jackh726 jackh726 commented Jun 28, 2021

No description provided.

@rust-highfive
Copy link
Contributor

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 28, 2021
@jackh726
Copy link
Member Author

r? @Mark-Simulacrum

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 28, 2021
@bors
Copy link
Collaborator

bors commented Jun 28, 2021

⌛ Trying commit e55c0ae with merge 6c472d3e5a0bced1c924884bd0687b4ed4e3c77a...

@bors
Copy link
Collaborator

bors commented Jun 28, 2021

☀️ Try build successful - checks-actions
Build commit: 6c472d3e5a0bced1c924884bd0687b4ed4e3c77a (6c472d3e5a0bced1c924884bd0687b4ed4e3c77a)

@rust-timer
Copy link
Collaborator

Queued 6c472d3e5a0bced1c924884bd0687b4ed4e3c77a with parent 17ea490, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (6c472d3e5a0bced1c924884bd0687b4ed4e3c77a): comparison url.

Summary: This change led to significant improvements 🎉 in compiler performance.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 28, 2021
@Mark-Simulacrum
Copy link
Member

@bors r+

I think this makes sense -- looks like a few solid improvements and tiny regressions on some other benchmarks.

@bors
Copy link
Collaborator

bors commented Jun 28, 2021

📌 Commit e55c0ae has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2021
@bors
Copy link
Collaborator

bors commented Jun 29, 2021

⌛ Testing commit e55c0ae with merge f12d91f...

@bors
Copy link
Collaborator

bors commented Jun 29, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing f12d91f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 29, 2021
@bors bors merged commit f12d91f into rust-lang:master Jun 29, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jun 29, 2021
@jackh726 jackh726 deleted the pgo branch June 29, 2021 16:03
@jackh726 jackh726 restored the pgo branch March 12, 2022 18:30
@jackh726 jackh726 deleted the pgo branch March 12, 2022 18:36
@jackh726 jackh726 restored the pgo branch March 12, 2022 18:42
@jackh726 jackh726 deleted the pgo branch March 12, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants