extra::json: use a different encoding for enums. #8437
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now uses `{"type": VariantName, "fields": [...]}`, which, according to
@Seldaek, since all enums will have the same "shape" rather than being a weird
ad-hoc array, will optimize better in javascript JITs. It also looks prettier,
and makes more sense.
|
Well, it mostly works, that is. |
| @@ -1522,7 +1533,7 @@ mod tests { | |||
| let mut encoder = Encoder(wr); | |||
| animal.encode(&mut encoder); | |||
| }, | |||
| ~"[\"Frog\",\"Henry\",349]" | |||
| ~"{\"type\":\"Frog\",\"fields\":[\"Henry\",349]}" | |||
There was a problem hiding this comment.
still says type here and below
|
@cmr Needs a rebase. |
|
I'm just going to close this for now since it's broke and I don't have the motivation to figure out why. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 20, 2022
Replace manual let else patterns with let else Clears the codebase from places where the lint added by rust-lang#8437 is firing, by adopting let else. changelog: none
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 21, 2022
Add lint to tell about let else pattern Adds a lint to tell the user if the let_else pattern should be used. ~~The PR is blocked probably on rustfmt support, as clippy shouldn't suggest features that aren't yet fully supported by all tools.~~ Edit: I guess adding it as a restriction lint for now is the best option, it can be turned into a style lint later. --- changelog: addition of a new lint to check for manual `let else`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now uses
{"type": VariantName, "fields": [...]}, which, according to@Seldaek, since all enums will have the same "shape" rather than being a weird
ad-hoc array, will optimize better in javascript JITs. It also looks prettier,
and makes more sense.