-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Ignore proc-macros when assembling rustc libdir #80315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
I just re-read the explanation of dual proc macros - https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/-Z.20dual-proc-macros. I think this should be fine, presuming my model that $sysroot/lib/ exists only for runtime linkage of rustc (and tool) binaries is accurate. The proc macro libraries dropped by this PR are currently still needed in the $sysroot/lib/rustlib/$host/lib and $sysroot/lib/rustlib/$target/lib when cross-compiling plugins/drivers from $host to $target, but $sysroot/lib should not be in the compiler's search path at that time I believe (but am somewhat unsure). AFAICT, this PR should not change the contents of the rustlib directory. |
I more or less remember why If both proc-macros-for-target and proc-macros-for-host were previously shipped together with other-artifacts-for-target, and now only proc-macros-for-target are shipped, then it should be ok. |
In any case, this can be reverted later if something breaks. |
@bors r+ rollup=never |
📌 Commit 3271681 has been approved by |
☀️ Test successful - checks-actions |
Fixes #80294.