Skip to content

Tweak diagnostics on shadowing lifetimes/labels #79620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

JohnTitor
Copy link
Member

Fixes #79610

Skip adding a new test assuming we have already sufficient tests.

@rust-highfive
Copy link
Contributor

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 2, 2020
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 3, 2020

📌 Commit cdcce11 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 3, 2020
@bors
Copy link
Collaborator

bors commented Dec 3, 2020

⌛ Testing commit cdcce11 with merge 5be3f9f...

@bors
Copy link
Collaborator

bors commented Dec 3, 2020

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing 5be3f9f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 3, 2020
@bors bors merged commit 5be3f9f into rust-lang:master Dec 3, 2020
@rustbot rustbot added this to the 1.50.0 milestone Dec 3, 2020
@JohnTitor JohnTitor deleted the label-name-sugg branch December 3, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Label-shadowing warning incorrectly calls a label 'lifetime'
5 participants