Skip to content

Small perf changes for InstCombine #79084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 29, 2020
Merged

Conversation

simonvandel
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 15, 2020
@Xanewok
Copy link
Member

Xanewok commented Nov 16, 2020

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Collaborator

bors commented Nov 16, 2020

⌛ Trying commit 3d5a1e3 with merge d91a689b00fbcb98ad332dfba5c82a4f606d5695...

@bors
Copy link
Collaborator

bors commented Nov 16, 2020

☀️ Try build successful - checks-actions
Build commit: d91a689b00fbcb98ad332dfba5c82a4f606d5695 (d91a689b00fbcb98ad332dfba5c82a4f606d5695)

@rust-timer
Copy link
Collaborator

Queued d91a689b00fbcb98ad332dfba5c82a4f606d5695 with parent f5230fb, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (d91a689b00fbcb98ad332dfba5c82a4f606d5695): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot modify labels: +S-waiting-on-review -S-waiting-on-perf

@simonvandel
Copy link
Contributor Author

Seems like a small win for some benchmarks without any regressions.

@camelid camelid added the A-mir-opt Area: MIR optimizations label Dec 4, 2020
@camelid
Copy link
Member

camelid commented Dec 4, 2020

I think Oli might be a better reviewer for this?

r? @oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned estebank Dec 4, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Dec 28, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 28, 2020

📌 Commit 0010fc8 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 28, 2020
@bors
Copy link
Collaborator

bors commented Dec 29, 2020

⌛ Testing commit 0010fc8 with merge e2a2592...

@bors
Copy link
Collaborator

bors commented Dec 29, 2020

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing e2a2592 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 29, 2020
@bors bors merged commit e2a2592 into rust-lang:master Dec 29, 2020
@rustbot rustbot added this to the 1.51.0 milestone Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-mir-opt Area: MIR optimizations merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants