Skip to content

Prevent stack overflow in deeply nested types. #76985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

hbina
Copy link
Contributor

@hbina hbina commented Sep 20, 2020

Related issue #75577 (?)

Unfortunately, I am unable to test whether this actually solves the problem because apparently, 12GB RAM + 2GB swap is not enough to compile the (admittedly toy) source file.

@rust-highfive
Copy link
Contributor

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 20, 2020
@hbina hbina marked this pull request as ready for review September 21, 2020 21:35
@estebank
Copy link
Contributor

estebank commented Oct 2, 2020

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Collaborator

bors commented Oct 2, 2020

⌛ Trying commit dc655b2 with merge ea21f00b89d83807014350c2c6c2b0caa5955c00...

@bors
Copy link
Collaborator

bors commented Oct 2, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: ea21f00b89d83807014350c2c6c2b0caa5955c00 (ea21f00b89d83807014350c2c6c2b0caa5955c00)

@rust-timer
Copy link
Collaborator

Queued ea21f00b89d83807014350c2c6c2b0caa5955c00 with parent f283d3f, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (ea21f00b89d83807014350c2c6c2b0caa5955c00): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

@estebank
Copy link
Contributor

estebank commented Oct 6, 2020

Let's merge so that @AuroransSolis can test on nightly.

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 6, 2020

📌 Commit dc655b2 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2020
@bors
Copy link
Collaborator

bors commented Oct 6, 2020

⌛ Testing commit dc655b2 with merge 8dfb988ddd09afc3df3f881523c6babad8a76661...

@bors
Copy link
Collaborator

bors commented Oct 6, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 6, 2020
@rust-log-analyzer
Copy link
Collaborator

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@estebank
Copy link
Contributor

estebank commented Oct 7, 2020

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 7, 2020
@bors
Copy link
Collaborator

bors commented Oct 7, 2020

⌛ Testing commit dc655b2 with merge 91a79fb...

@bors
Copy link
Collaborator

bors commented Oct 7, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: estebank
Pushing 91a79fb to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 7, 2020
@bors bors merged commit 91a79fb into rust-lang:master Oct 7, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 7, 2020
@hbina hbina deleted the clone_check branch October 8, 2020 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants