-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Use WASM's saturating casts if they are available #73724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
94cd4f1
Use WASM's saturating casts if they are available
CryZe b249029
Check for feature with pre-interned symbol
CryZe 4c08451
Add codegen tests
CryZe 8f8c90e
Add comments and format the code
CryZe 838c497
Address review comments and add UI test
CryZe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,162 @@ | ||
// only-wasm32 | ||
// compile-flags: -C target-feature=+nontrapping-fptoint | ||
#![crate_type = "lib"] | ||
|
||
// CHECK-LABEL: @cast_f64_i64 | ||
#[no_mangle] | ||
pub fn cast_f64_i64(a: f64) -> i64 { | ||
// CHECK: tail call i64 @llvm.wasm.trunc.saturate.signed.i64.f64(double {{.*}}) | ||
// CHECK-NEXT: ret i64 {{.*}} | ||
a as _ | ||
} | ||
|
||
// CHECK-LABEL: @cast_f64_i32 | ||
#[no_mangle] | ||
pub fn cast_f64_i32(a: f64) -> i32 { | ||
// CHECK: tail call i32 @llvm.wasm.trunc.saturate.signed.i32.f64(double {{.*}}) | ||
// CHECK-NEXT: ret i32 {{.*}} | ||
a as _ | ||
} | ||
|
||
// CHECK-LABEL: @cast_f32_i64 | ||
#[no_mangle] | ||
pub fn cast_f32_i64(a: f32) -> i64 { | ||
// CHECK: tail call i64 @llvm.wasm.trunc.saturate.signed.i64.f32(float {{.*}}) | ||
// CHECK-NEXT: ret i64 {{.*}} | ||
a as _ | ||
} | ||
|
||
// CHECK-LABEL: @cast_f32_i32 | ||
#[no_mangle] | ||
pub fn cast_f32_i32(a: f32) -> i32 { | ||
// CHECK: tail call i32 @llvm.wasm.trunc.saturate.signed.i32.f32(float {{.*}}) | ||
// CHECK-NEXT: ret i32 {{.*}} | ||
a as _ | ||
} | ||
|
||
|
||
// CHECK-LABEL: @cast_f64_u64 | ||
#[no_mangle] | ||
pub fn cast_f64_u64(a: f64) -> u64 { | ||
// CHECK: tail call i64 @llvm.wasm.trunc.saturate.unsigned.i64.f64(double {{.*}}) | ||
// CHECK-NEXT: ret i64 {{.*}} | ||
a as _ | ||
} | ||
|
||
// CHECK-LABEL: @cast_f64_u32 | ||
#[no_mangle] | ||
pub fn cast_f64_u32(a: f64) -> u32 { | ||
// CHECK: tail call i32 @llvm.wasm.trunc.saturate.unsigned.i32.f64(double {{.*}}) | ||
// CHECK-NEXT: ret i32 {{.*}} | ||
a as _ | ||
} | ||
|
||
// CHECK-LABEL: @cast_f32_u64 | ||
#[no_mangle] | ||
pub fn cast_f32_u64(a: f32) -> u64 { | ||
// CHECK: tail call i64 @llvm.wasm.trunc.saturate.unsigned.i64.f32(float {{.*}}) | ||
// CHECK-NEXT: ret i64 {{.*}} | ||
a as _ | ||
} | ||
|
||
// CHECK-LABEL: @cast_f32_u32 | ||
#[no_mangle] | ||
pub fn cast_f32_u32(a: f32) -> u32 { | ||
// CHECK: tail call i32 @llvm.wasm.trunc.saturate.unsigned.i32.f32(float {{.*}}) | ||
// CHECK-NEXT: ret i32 {{.*}} | ||
a as _ | ||
} | ||
|
||
// CHECK-LABEL: @cast_f32_u8 | ||
#[no_mangle] | ||
pub fn cast_f32_u8(a: f32) -> u8 { | ||
// CHECK-NOT: {{.*}} call {{.*}} @llvm.wasm.trunc.{{.*}} | ||
// CHECK: fptoui float {{.*}} to i8 | ||
// CHECK-NEXT: select i1 {{.*}}, i8 {{.*}}, i8 {{.*}} | ||
// CHECK-NEXT: ret i8 {{.*}} | ||
a as _ | ||
} | ||
|
||
|
||
|
||
// CHECK-LABEL: @cast_unchecked_f64_i64 | ||
#[no_mangle] | ||
pub unsafe fn cast_unchecked_f64_i64(a: f64) -> i64 { | ||
// CHECK-NOT: {{.*}} call {{.*}} @llvm.wasm.trunc.{{.*}} | ||
// CHECK: fptosi double {{.*}} to i64 | ||
// CHECK-NEXT: ret i64 {{.*}} | ||
a.to_int_unchecked() | ||
} | ||
|
||
// CHECK-LABEL: @cast_unchecked_f64_i32 | ||
#[no_mangle] | ||
pub unsafe fn cast_unchecked_f64_i32(a: f64) -> i32 { | ||
// CHECK-NOT: {{.*}} call {{.*}} @llvm.wasm.trunc.{{.*}} | ||
// CHECK: fptosi double {{.*}} to i32 | ||
// CHECK-NEXT: ret i32 {{.*}} | ||
a.to_int_unchecked() | ||
} | ||
|
||
// CHECK-LABEL: @cast_unchecked_f32_i64 | ||
#[no_mangle] | ||
pub unsafe fn cast_unchecked_f32_i64(a: f32) -> i64 { | ||
// CHECK-NOT: {{.*}} call {{.*}} @llvm.wasm.trunc.{{.*}} | ||
// CHECK: fptosi float {{.*}} to i64 | ||
// CHECK-NEXT: ret i64 {{.*}} | ||
a.to_int_unchecked() | ||
} | ||
|
||
// CHECK-LABEL: @cast_unchecked_f32_i32 | ||
#[no_mangle] | ||
pub unsafe fn cast_unchecked_f32_i32(a: f32) -> i32 { | ||
// CHECK-NOT: {{.*}} call {{.*}} @llvm.wasm.trunc.{{.*}} | ||
// CHECK: fptosi float {{.*}} to i32 | ||
// CHECK-NEXT: ret i32 {{.*}} | ||
a.to_int_unchecked() | ||
} | ||
|
||
|
||
// CHECK-LABEL: @cast_unchecked_f64_u64 | ||
#[no_mangle] | ||
pub unsafe fn cast_unchecked_f64_u64(a: f64) -> u64 { | ||
// CHECK-NOT: {{.*}} call {{.*}} @llvm.wasm.trunc.{{.*}} | ||
// CHECK: fptoui double {{.*}} to i64 | ||
// CHECK-NEXT: ret i64 {{.*}} | ||
a.to_int_unchecked() | ||
} | ||
|
||
// CHECK-LABEL: @cast_unchecked_f64_u32 | ||
#[no_mangle] | ||
pub unsafe fn cast_unchecked_f64_u32(a: f64) -> u32 { | ||
// CHECK-NOT: {{.*}} call {{.*}} @llvm.wasm.trunc.{{.*}} | ||
// CHECK: fptoui double {{.*}} to i32 | ||
// CHECK-NEXT: ret i32 {{.*}} | ||
a.to_int_unchecked() | ||
} | ||
|
||
// CHECK-LABEL: @cast_unchecked_f32_u64 | ||
#[no_mangle] | ||
pub unsafe fn cast_unchecked_f32_u64(a: f32) -> u64 { | ||
// CHECK-NOT: {{.*}} call {{.*}} @llvm.wasm.trunc.{{.*}} | ||
// CHECK: fptoui float {{.*}} to i64 | ||
// CHECK-NEXT: ret i64 {{.*}} | ||
a.to_int_unchecked() | ||
} | ||
|
||
// CHECK-LABEL: @cast_unchecked_f32_u32 | ||
#[no_mangle] | ||
pub unsafe fn cast_unchecked_f32_u32(a: f32) -> u32 { | ||
// CHECK-NOT: {{.*}} call {{.*}} @llvm.wasm.trunc.{{.*}} | ||
// CHECK: fptoui float {{.*}} to i32 | ||
// CHECK-NEXT: ret i32 {{.*}} | ||
a.to_int_unchecked() | ||
} | ||
|
||
// CHECK-LABEL: @cast_unchecked_f32_u8 | ||
#[no_mangle] | ||
pub unsafe fn cast_unchecked_f32_u8(a: f32) -> u8 { | ||
// CHECK-NOT: {{.*}} call {{.*}} @llvm.wasm.trunc.{{.*}} | ||
// CHECK: fptoui float {{.*}} to i8 | ||
// CHECK-NEXT: ret i8 {{.*}} | ||
a.to_int_unchecked() | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.