Skip to content

Fix Into trait docs links #61929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2019
Merged

Fix Into trait docs links #61929

merged 1 commit into from
Jun 20, 2019

Conversation

95th
Copy link
Contributor

@95th 95th commented Jun 18, 2019

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @TimNN (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 18, 2019
tesuji
tesuji reviewed Jun 18, 2019
View reviewed changes
GuillaumeGomez
GuillaumeGomez reviewed Jun 18, 2019
View reviewed changes
GuillaumeGomez
GuillaumeGomez reviewed Jun 18, 2019
View reviewed changes
GuillaumeGomez
GuillaumeGomez requested changes Jun 18, 2019
View reviewed changes
Copy link
Member

@GuillaumeGomez GuillaumeGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot a few Into (two other at line 254 and 257)

@95th
Copy link
Contributor Author

95th commented Jun 18, 2019 •
edited
Loading

@GuillaumeGomez Do I need to create a separate link for Into<T> or the one for Into will work?
Perhaps: [`Into`]`<T>` ?

tesuji
tesuji reviewed Jun 18, 2019
View reviewed changes
@95th
Copy link
Contributor Author

95th commented Jun 19, 2019

r? @GuillaumeGomez

@tesuji
Copy link
Contributor

tesuji commented Jun 20, 2019 •
edited
Loading

Could you squash all commits to one with message: Fix Into trait links?
Also edit the PR title appropriately?

@95th 95th changed the title Fix docs display Fix Into trait docs links Jun 20, 2019
@95th
Copy link
Contributor Author

95th commented Jun 20, 2019

@lzutao I've made the suggested changes

@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 20, 2019

📌 Commit 34188fb has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2019
@bors
Copy link
Collaborator

bors commented Jun 20, 2019

⌛ Testing commit 34188fb with merge c1a5edd...

bors added a commit that referenced this pull request Jun 20, 2019
@bors
Auto merge of #61929 - 95th:master, r=GuillaumeGomez
c1a5edd 
Fix Into trait docs links

https://doc.rust-lang.org/std/convert/trait.Into.html
@bors
Copy link
Collaborator

bors commented Jun 20, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: GuillaumeGomez
Pushing c1a5edd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 20, 2019
@bors bors merged commit 34188fb into rust-lang:master Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tesuji tesuji tesuji left review comments

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@95th @rust-highfive @tesuji @GuillaumeGomez @bors @TimNN