Skip to content

Update musl-cross-make to 0.9.8 #61300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2019
Merged

Conversation

indygreg
Copy link
Contributor

This version uses musl 1.1.22 and GCC 6.4.0 by default. It also
contains support for newer binutils and GCC versions, should we
want to bump those as well. But I'm purposefully limiting this
patch in order to reduce the surface area for controversy.

This version uses musl 1.1.22 and GCC 6.4.0 by default. It also
contains support for newer binutils and GCC versions, should we
want to bump those as well. But I'm purposefully limiting this
patch in order to reduce the surface area for controversy.
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 29, 2019
@sanxiyn
Copy link
Member

sanxiyn commented May 29, 2019

This may need retries because of build timeout due to invalidation of build cache.

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented May 29, 2019

📌 Commit 51b47b8 has been approved by sanxiyn

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 29, 2019
@Centril
Copy link
Contributor

Centril commented May 30, 2019

@bors p=1

because never.

@bors
Copy link
Collaborator

bors commented May 31, 2019

⌛ Testing commit 51b47b8 with merge 6f5b0275409e7bfbade75be8c534ad09b408cf30...

@Centril
Copy link
Contributor

Centril commented May 31, 2019

@bors retry

@rust-highfive
Copy link
Contributor

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
Checking out files: 100% (18347/18347), done.
travis_time:end:0997b379:start=1559270664876664000,finish=1559270675437118000,duration=10560454000
$ cd rust-lang/rust
$ git checkout -qf 6f5b0275409e7bfbade75be8c534ad09b408cf30
fatal: reference is not a tree: 6f5b0275409e7bfbade75be8c534ad09b408cf30
The command "git checkout -qf 6f5b0275409e7bfbade75be8c534ad09b408cf30" failed and exited with 128 during .
Your build has been stopped.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Collaborator

bors commented May 31, 2019

⌛ Testing commit 51b47b8 with merge 0c833420bac92dd83471b20ea18fe7ec946c42f1...

@bors
Copy link
Collaborator

bors commented May 31, 2019

💔 Test failed - checks-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 31, 2019
@rust-highfive
Copy link
Contributor

The job dist-x86_64-musl of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:11:41] + cd -
[00:11:41] + ln -s /usr/local/x86_64-linux-musl/lib/libc.so /lib/ld-musl-x86_64.so.1
[00:11:41] /build
[00:11:41] + echo /usr/local/x86_64-linux-musl/lib
[00:11:41] + '[' 1 = 1 ']'
[00:11:41] + for exec in cc gcc
[00:11:41] + ln -s x86_64-linux-musl-gcc /usr/local/bin/cc
[00:11:41] + for exec in cc gcc
[00:11:41] + ln -s x86_64-linux-musl-gcc /usr/local/bin/gcc
[00:11:41] + for exec in cpp c++ g++
[00:11:41] + ln -s x86_64-linux-musl-g++ /usr/local/bin/cpp
[00:11:41] + for exec in cpp c++ g++
[00:11:41] + ln -s x86_64-linux-musl-g++ /usr/local/bin/c++
[00:11:41] + for exec in cpp c++ g++
[00:11:41] + ln -s x86_64-linux-musl-g++ /usr/local/bin/g++
[00:11:41] + CC=x86_64-linux-musl-gcc
[00:11:41] + export CXX=x86_64-linux-musl-g++
[00:11:41] + CXX=x86_64-linux-musl-g++
[00:11:41] + LLVM=70

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@sanxiyn
Copy link
Member

sanxiyn commented May 31, 2019

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 31, 2019
@bors
Copy link
Collaborator

bors commented May 31, 2019

⌛ Testing commit 51b47b8 with merge 041bec8...

bors added a commit that referenced this pull request May 31, 2019
Update musl-cross-make to 0.9.8

This version uses musl 1.1.22 and GCC 6.4.0 by default. It also
contains support for newer binutils and GCC versions, should we
want to bump those as well. But I'm purposefully limiting this
patch in order to reduce the surface area for controversy.
@bors
Copy link
Collaborator

bors commented Jun 1, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: sanxiyn
Pushing 041bec8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 1, 2019
@bors bors merged commit 51b47b8 into rust-lang:master Jun 1, 2019
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #61300!

Tested on commit 041bec8.
Direct link to PR: #61300

🎉 rls on windows: test-fail → test-pass (cc @Xanewok, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jun 1, 2019
Tested on commit rust-lang/rust@041bec8.
Direct link to PR: <rust-lang/rust#61300>

🎉 rls on windows: test-fail → test-pass (cc @Xanewok, @rust-lang/infra).
@indygreg indygreg deleted the upgrade-cross-make branch June 1, 2019 01:40
@sanxiyn sanxiyn mentioned this pull request Jun 12, 2019
@alexcrichton
Copy link
Member

@indygreg out of curiosity, do you know of a way to report bugs to musl? This update is the cause (I think at least) of new spurious deadlocks we're seeing on CI, and I've traced it to what I believe is a particular commit in musl and I figure it'd be good to tell them about that.

@mati865
Copy link
Member

mati865 commented Jun 27, 2019

@alexcrichton the are using mailing list for it but you could also try IRC: https://www.musl-libc.org/support.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants