-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Update musl-cross-make to 0.9.8 #61300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This version uses musl 1.1.22 and GCC 6.4.0 by default. It also contains support for newer binutils and GCC versions, should we want to bump those as well. But I'm purposefully limiting this patch in order to reduce the surface area for controversy.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
This may need retries because of build timeout due to invalidation of build cache. @bors r+ rollup=never |
📌 Commit 51b47b8 has been approved by |
@bors p=1 because never. |
⌛ Testing commit 51b47b8 with merge 6f5b0275409e7bfbade75be8c534ad09b408cf30... |
@bors retry |
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
⌛ Testing commit 51b47b8 with merge 0c833420bac92dd83471b20ea18fe7ec946c42f1... |
💔 Test failed - checks-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors retry |
Update musl-cross-make to 0.9.8 This version uses musl 1.1.22 and GCC 6.4.0 by default. It also contains support for newer binutils and GCC versions, should we want to bump those as well. But I'm purposefully limiting this patch in order to reduce the surface area for controversy.
☀️ Test successful - checks-travis, status-appveyor |
Tested on commit rust-lang/rust@041bec8. Direct link to PR: <rust-lang/rust#61300> 🎉 rls on windows: test-fail → test-pass (cc @Xanewok, @rust-lang/infra).
@indygreg out of curiosity, do you know of a way to report bugs to musl? This update is the cause (I think at least) of new spurious deadlocks we're seeing on CI, and I've traced it to what I believe is a particular commit in musl and I figure it'd be good to tell them about that. |
@alexcrichton the are using mailing list for it but you could also try IRC: https://www.musl-libc.org/support.html |
This version uses musl 1.1.22 and GCC 6.4.0 by default. It also
contains support for newer binutils and GCC versions, should we
want to bump those as well. But I'm purposefully limiting this
patch in order to reduce the surface area for controversy.