libcore: rand refactor & remove @'s from {rand,run}.rs #6036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feel like |
|
That seems reasonable. (edit: done!) |
Also, rename RandRes -> IsaacRng, and make the constructors static methods.
Removes the dynamic @ indirection, and also converts the functions acting on `ProgRepr`s to methods.
…ic `gen`. This moves all the basic random value generation into the Rand instances for each type and then removes the `gen_int`, `gen_char` (etc) methods on RngUtil, leaving only the generic `gen` and the more specialised methods. Also, removes some imports that are redundant due to a `use core::prelude::*` statement.
|
r+ This looks good; we may also want to implement the trait so that people can use the object type should they choose to (sometimes it's more convenient). |
|
Oh, I see you already did that, I missed it. |
bors
added a commit
that referenced
this pull request
Apr 24, 2013
From a cursory `git grep` this removes the last part of `core` that requires on `@` (other than `io` and the task local data section). It renames `RandRes` to ~~StdRng~~ `IsaacRng` and `XorShiftState` to `XorShiftRng` as well as moving their constructors to static methods. To go with this, it adds `rng()` which is designed to be used when the programmer just wants a random number generator, without caring about which exact algorithm is being used. It also removes all the `gen_int`, `gen_uint`, `gen_char` (etc) methods on `RngUtil` (by moving the defintions to the actual `Rand` instances). The replacement is using `RngUtil::gen`, either type-inferred or with an annotation (`rng.gen::<uint>()`). I tried to have the `Rng` and `RngUtil` traits exported by `core::prelude` (since `core::rand` (except for `random()`) is useless without them), but this caused [an explosion of (seemingly unrelated) `error: unresolved import`'s](https://gist.github.com/5451839).
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Sep 24, 2020
…ask_to_pedantic Downgrade `verbose_bit_mask` to pedantic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From a cursory
git grepthis removes the last part ofcorethat requires on@(other thanioand the task local data section).It renames
RandRestoStdRngIsaacRngandXorShiftStatetoXorShiftRngas well as moving their constructors to static methods. To go with this, it addsrng()which is designed to be used when the programmer just wants a random number generator, without caring about which exact algorithm is being used.It also removes all the
gen_int,gen_uint,gen_char(etc) methods onRngUtil(by moving the defintions to the actualRandinstances). The replacement is usingRngUtil::gen, either type-inferred or with an annotation (rng.gen::<uint>()).I tried to have the
RngandRngUtiltraits exported bycore::prelude(sincecore::rand(except forrandom()) is useless without them), but this caused an explosion of (seemingly unrelated)error: unresolved import's.