Skip to content

Issue 3488 #4346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Issue 3488 #4346

wants to merge 4 commits into from

Conversation

sanxiyn
Copy link
Member

@sanxiyn sanxiyn commented Jan 4, 2013

Fix for #3488.
Needs tests.
Needs to fix the pretty printer. (Help appreciated.)

@brson
Copy link
Contributor

brson commented Jan 7, 2013

Thanks!

There are some notes on how to operate the test suite here: https://github.com/mozilla/rust/wiki/Note-testsuite

I'd suggest that this needs at least one test for 'mut' in normal function arguments, another in closure arguments, and the corresponding negative (compile-fail) tests that non-mutable arguments can't be mutated.

The pretty printer should be fairly straightforward, just find the code that prints function arguments and add mut if necessary.

@catamorphism
Copy link
Contributor

I'm going to take the liberty of finishing this, since it's been sitting for a while.

@sanxiyn
Copy link
Member Author

sanxiyn commented Jan 23, 2013

Thanks, and sorry for not following up. Feel free to take over.

@catamorphism
Copy link
Contributor

I fixed the pretty-printer and added tests. Merged as of 54344c2 -- thanks!

RalfJung added a commit to RalfJung/rust that referenced this pull request Jun 1, 2025
./miri bench: sort results alphabetically
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants