Convert libstd to use the Drop trait #3962
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Working towards #3944 |
|
I suspect that the issue you are seeing is because of this rule: https://github.com/mozilla/rust/blob/incoming/mk/tests.mk#L95. If |
|
Merged. |
|
Thanks, @bstrie |
|
reverted. std tests aren't working on windows: http://bot.rust-lang.org/logs/2012/10/14/2012-11-14T22:43:24Z-be9c7d89-c6cf-4ae8-9883-a8ff03578c82.html |
|
thread_pool is the culprit |
|
I changed thread_pool back to drop blocks and pushed the rest to incoming |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 20, 2020
fix a false positive in two `interior_mutable_const` lints where a constant with enums gets linted even if it uses a clearly unfrozen variant. Note that the code uses the MIR interpreter, which the author of rust-lang#3962 thought unlikely to be a solution. This might be over-engineering; but, I think it's important to be able to work with the 'http' crate (rust-lang#3825).
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 20, 2020
…=llogiq "Respect" enums in `interior_mutable_const` fixes rust-lang#3962 fixes rust-lang#3825 Hello, It might not be a good idea to submit another relatively large PR while I have an opened PR; but, I've finished this anyway. This may be able to wait for months. Note: the code uses the MIR interpreter, which the author of rust-lang#3962 thought unlikely to be a solution. This might be over-engineering; but, I think it's important to be able to work with the 'http' crate (rust-lang#3825). (And, I don't want to write a MIR visitor) --- changelog: fix a false positive in two `interior_mutable_const` lints where a constant with enums gets linted even if it uses a clearly unfrozen variant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this code I've seen some intermittent failures when running
make -j8 check. pcwalton seems to think this is to do with some parallel check going wrong, as I can't seem to reproduce the errors with just a usualmake check(but they're nondeterministic errors in the first place, so that doesn't really say much). So there could be something lurking in here, but it's beyond my ken to track it down.