-
Notifications
You must be signed in to change notification settings - Fork 13.4k
std: impl From<String> for Box<Error + Send> #23979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
I've wanted this too, but if we're going to do this we should probably just take the clearer step conceptually of just implementing |
@reem hm I'm a little confused, this intentionally does not implement |
@alexcrichton this feels like a weird half-step to me and has some drawbacks. For instance, this doesn't expose the exact underlying type of the error and can't be used with traits that inherit from Error, e.g. rust-error. |
I'm saying that I think that implementing Error for String would be fine, and have more use cases than just this implementation. |
I personally feel that |
Hm, I'm torn on the question of making FWIW, taking the step here does not preclude us from making |
I agree with @alexcrichton and @aturon as well, that a separate distinct type is appropriate and that we probably don't want to make |
No description provided.