rustdoc: show negative impls properly in the implementors page #23809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't really possible to test in an automatic way, since the only traits you can negative impl are `Send` and `Sync`, and the implementors page for those only exists in libstd. Closes #21310
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
Note that there's some bug (that I'm still trying to track down) that leads to impls being double-counted. Currently the impl of |
|
@bors: r+ |
|
📌 Commit 8d6fb44 has been approved by |
bors
added a commit
that referenced
this pull request
Mar 29, 2015
This isn't really possible to test in an automatic way, since the only traits you can negative impl are `Send` and `Sync`, and the implementors page for those only exists in libstd. Closes #21310
|
@cmr Sorry I was away and couldn't review this, but thanks for jumping in on these issues! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't really possible to test in an automatic way, since the only traits
you can negative impl are
SendandSync, and the implementors page forthose only exists in libstd.
Closes #21310