std: Don't parse argv as a String #20100
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Instead, just pass everything through as a Vec<u8> to get worried about later. Closes rust-lang#20091
alexcrichton
force-pushed
the
issue-20091
branch
from
57fddf8 to
5ef9796
Compare
| let mut len = 0u; | ||
| while *arg.offset(len as int) != 0 { | ||
| len += 1u; | ||
| } |
There was a problem hiding this comment.
Can't this use CString, instead of duplicating that logic?
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Dec 21, 2014
Instead, just pass everything through as a Vec<u8> to get worried about later. Closes rust-lang#20091
|
Rolled into #20104 (must've picked up the wrong commit...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, just pass everything through as a Vec to get worried about later.
Closes #20091