Skip to content

serialize: Fully deprecate the library in-tree #20033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2014

Conversation

alexcrichton
Copy link
Member

This commit completes the deprecation story for the in-tree serialization
library. The compiler will now emit a warning whenever it encounters
deriving(Encodable) or deriving(Decodable), and the library itself is now
marked #[unstable] for when feature staging is enabled.

All users of serialization can migrate to the rustc-serialize crate on
crates.io which provides the exact same interface as the libserialize library
in-tree. The new deriving modes are named RustcEncodable and RustcDecodable
and require extern crate "rustc-serialize" as rustc_serialize at the crate
root in order to expand correctly.

To migrate all crates, add the following to your Cargo.toml:

[dependencies]
rustc-serialize = "0.1.1"

And then add the following to your crate root:

extern crate "rustc-serialize" as rustc_serialize;

Finally, rename Encodable and Decodable deriving modes to RustcEncodable
and RustcDecodable.

[breaking-change]

@rust-highfive
Copy link
Contributor

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

This is currently rebased on #19972.

@alexcrichton alexcrichton force-pushed the deprecate-serialise branch 2 times, most recently from a2cd9e9 to ed65e3a Compare December 19, 2014 17:10
@alexcrichton
Copy link
Member Author

r? @aturon

Clone, Hash, Encodable, Decodable, Show)]
#[deriving(PartialOrd, Ord, PartialEq, Eq, Copy,
Clone, Hash, RustcEncodable, RustcDecodable, Show)]
>>>>>>> serialize: Fully deprecate the library
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be here?

This commit completes the deprecation story for the in-tree serialization
library. The compiler will now emit a warning whenever it encounters
`deriving(Encodable)` or `deriving(Decodable)`, and the library itself is now
marked `#[unstable]` for when feature staging is enabled.

All users of serialization can migrate to the `rustc-serialize` crate on
crates.io which provides the exact same interface as the libserialize library
in-tree. The new deriving modes are named `RustcEncodable` and `RustcDecodable`
and require `extern crate "rustc-serialize" as rustc_serialize` at the crate
root in order to expand correctly.

To migrate all crates, add the following to your `Cargo.toml`:

    [dependencies]
    rustc-serialize = "0.1.1"

And then add the following to your crate root:

    extern crate "rustc-serialize" as rustc_serialize;

Finally, rename `Encodable` and `Decodable` deriving modes to `RustcEncodable`
and `RustcDecodable`.

[breaking-change]
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Dec 22, 2014
This commit completes the deprecation story for the in-tree serialization
library. The compiler will now emit a warning whenever it encounters
`deriving(Encodable)` or `deriving(Decodable)`, and the library itself is now
marked `#[unstable]` for when feature staging is enabled.

All users of serialization can migrate to the `rustc-serialize` crate on
crates.io which provides the exact same interface as the libserialize library
in-tree. The new deriving modes are named `RustcEncodable` and `RustcDecodable`
and require `extern crate "rustc-serialize" as rustc_serialize` at the crate
root in order to expand correctly.

To migrate all crates, add the following to your `Cargo.toml`:

    [dependencies]
    rustc-serialize = "0.1.1"

And then add the following to your crate root:

    extern crate "rustc-serialize" as rustc_serialize;

Finally, rename `Encodable` and `Decodable` deriving modes to `RustcEncodable`
and `RustcDecodable`.

[breaking-change]
@bors bors merged commit a76a802 into rust-lang:master Dec 23, 2014
@alexcrichton alexcrichton deleted the deprecate-serialise branch December 23, 2014 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants