-
Notifications
You must be signed in to change notification settings - Fork 13.4k
serialize: Fully deprecate the library in-tree #20033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
This is currently rebased on #19972. |
a2cd9e9
to
ed65e3a
Compare
r? @aturon |
8835328
to
087adbd
Compare
087adbd
to
1b152a4
Compare
1b152a4
to
016685f
Compare
Clone, Hash, Encodable, Decodable, Show)] | ||
#[deriving(PartialOrd, Ord, PartialEq, Eq, Copy, | ||
Clone, Hash, RustcEncodable, RustcDecodable, Show)] | ||
>>>>>>> serialize: Fully deprecate the library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be here?
016685f
to
c60ef3b
Compare
c60ef3b
to
d748bb7
Compare
This commit completes the deprecation story for the in-tree serialization library. The compiler will now emit a warning whenever it encounters `deriving(Encodable)` or `deriving(Decodable)`, and the library itself is now marked `#[unstable]` for when feature staging is enabled. All users of serialization can migrate to the `rustc-serialize` crate on crates.io which provides the exact same interface as the libserialize library in-tree. The new deriving modes are named `RustcEncodable` and `RustcDecodable` and require `extern crate "rustc-serialize" as rustc_serialize` at the crate root in order to expand correctly. To migrate all crates, add the following to your `Cargo.toml`: [dependencies] rustc-serialize = "0.1.1" And then add the following to your crate root: extern crate "rustc-serialize" as rustc_serialize; Finally, rename `Encodable` and `Decodable` deriving modes to `RustcEncodable` and `RustcDecodable`. [breaking-change]
d748bb7
to
a76a802
Compare
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Dec 22, 2014
This commit completes the deprecation story for the in-tree serialization library. The compiler will now emit a warning whenever it encounters `deriving(Encodable)` or `deriving(Decodable)`, and the library itself is now marked `#[unstable]` for when feature staging is enabled. All users of serialization can migrate to the `rustc-serialize` crate on crates.io which provides the exact same interface as the libserialize library in-tree. The new deriving modes are named `RustcEncodable` and `RustcDecodable` and require `extern crate "rustc-serialize" as rustc_serialize` at the crate root in order to expand correctly. To migrate all crates, add the following to your `Cargo.toml`: [dependencies] rustc-serialize = "0.1.1" And then add the following to your crate root: extern crate "rustc-serialize" as rustc_serialize; Finally, rename `Encodable` and `Decodable` deriving modes to `RustcEncodable` and `RustcDecodable`. [breaking-change]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit completes the deprecation story for the in-tree serialization
library. The compiler will now emit a warning whenever it encounters
deriving(Encodable)
orderiving(Decodable)
, and the library itself is nowmarked
#[unstable]
for when feature staging is enabled.All users of serialization can migrate to the
rustc-serialize
crate oncrates.io which provides the exact same interface as the libserialize library
in-tree. The new deriving modes are named
RustcEncodable
andRustcDecodable
and require
extern crate "rustc-serialize" as rustc_serialize
at the crateroot in order to expand correctly.
To migrate all crates, add the following to your
Cargo.toml
:And then add the following to your crate root:
Finally, rename
Encodable
andDecodable
deriving modes toRustcEncodable
and
RustcDecodable
.[breaking-change]