Add a doctest for the entry method of BTreeMap. #19711
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @gankro |
| /// match map.entry("b") { | ||
| /// Entry::Vacant(_) => unreachable!(), | ||
| /// Entry::Occupied(view) => assert_eq!(*view.get(), 2u), | ||
| /// } |
There was a problem hiding this comment.
This isn't very idiomatic "entry" code, to be honest. Generally when you're working with entry you're genuinely uncertain if the value is contained, and have something useful to do in both cases. If you "know" the value is-or-isn't there, you should be using indexing or insert.
See the top-level collection docs for some examples I wrote.
|
@jbranchaud ping |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Dec 22, 2014
…entry This is an updated version of rust-lang#19711. The merge and subsequent rebase on that branch were more trouble than they were worth, so I am just resubmitting the relevant change here. If this PR is accepted, then rust-lang#19711 can be closed. /cc @gankro
|
This can be closed now. #20134 landed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.