Skip to content

expand description of the link attribute #18373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2014
Merged

Conversation

steveklabnik
Copy link
Member

Fixes #18288

I'm not sure if the entire information from the FFI guide should go here or not. http://doc.rust-lang.org/nightly/guide-ffi.html#linking

I'm thinking maybe that should all go in the reference. This is just the smallest change. What do you think, @huonw ?

@@ -1957,8 +1957,10 @@ On an `extern` block, the following attributes are interpreted:
name and type. This is feature gated and the exact behavior is
implementation-defined (due to variety of linker invocation syntax).
- `link` - indicate that a native library should be linked to for the
declarations in this block to be linked correctly. See [external
blocks](#external-blocks)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems unfortunate to lose this link.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I guess I just assumed that since this entire section was about extern blocks, it seemed gratuituos

@steveklabnik
Copy link
Member Author

@huonw updated

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Nov 6, 2014
@bors bors merged commit d108613 into rust-lang:master Nov 7, 2014
lnicola pushed a commit to lnicola/rust that referenced this pull request Oct 29, 2024
…nxqu

internal: Merge separate inlay hints targeting same range
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reference needs to document kind key of #[link]
4 participants