move most of front to libsyntax #16240
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -73,8 +76,6 @@ pub fn modify_for_testing(sess: &Session, | |||
|
|
|||
| struct TestHarnessGenerator<'a> { | |||
| cx: TestCtxt<'a>, | |||
| tests: Vec<ast::Ident>, | |||
| tested_submods: Vec<ast::Ident>, | |||
There was a problem hiding this comment.
Is this a merge conflict gone awry?
There was a problem hiding this comment.
I think so. This seems to revert #16034.
|
I won't object to this, but could we maybe make this a separate crate to reduce memory consumption of the build? |
|
@pcwalton These should be small enough, and they can be reduced further IMO. |
|
ping @nick29581, any progress on this? |
|
Closing due to inactivity, but this would be awesome to have! |
|
Let this slide, sorry. New PR coming up soon |
|
@nick29581 we should coordinate so no pointless conflicts happen with #13316. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to move all of front to libsyntax but feature_gate.rs and std_inject.rs have small but annoying dependencies on other rustc stuff. So I'm not really sure if moving just this stuff is worthwhile, but it does seem a bit of a better fit in libsyntax.
r?