librustc: Remove the &LIFETIME EXPR production from the language.
#15405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was parsed by the parser but completely ignored; not even stored in
the AST!
This breaks code that looks like:
static X: &'static [u8] = &'static [1, 2, 3];
Change this code to the shorter:
static X: &'static [u8] = &[1, 2, 3];
Closes rust-lang#15312.
[breaking-change]
|
It seems a shame to remove this instead of making it work. |
|
@kballard we can put it back in later and make it work at that time. The point right now is to reduce the surface of potential future backwards-incompatible changes. So by removing this now, we improve our ability to make it work in the future, by ensuring that no one is using it in incompatible contexts. |
bors
added a commit
that referenced
this pull request
Jul 4, 2014
This was parsed by the parser but completely ignored; not even stored in
the AST!
This breaks code that looks like:
static X: &'static [u8] = &'static [1, 2, 3];
Change this code to the shorter:
static X: &'static [u8] = &[1, 2, 3];
Closes #15312.
[breaking-change]
r? @nick29581
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 21, 2023
…kril Support doc links that resolve to fields Fixes rust-lang#15331 Also removes `Resolver::resolve_module_path_in_trait_assoc_items()` and reimplements it in hir with other `Resolver` methods to decouple things a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was parsed by the parser but completely ignored; not even stored in
the AST!
This breaks code that looks like:
Change this code to the shorter:
Closes #15312.
[breaking-change]
r? @nick29581