Skip to content

Cleanup CodegenFnAttrFlags #141511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2025
Merged

Cleanup CodegenFnAttrFlags #141511

merged 1 commit into from
May 25, 2025

Conversation

Noratrieb
Copy link
Member

  • Rename USED to USED_COMPILER to better reflect its behavior.
  • Reorder some items to group the used and allocator flags together
  • Renumber them without gaps

@rustbot
Copy link
Collaborator

rustbot commented May 24, 2025

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 24, 2025

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred in compiler/rustc_codegen_ssa/src/codegen_attrs.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

@rust-log-analyzer

This comment has been minimized.

- Rename `USED` to `USED_COMPILER` to better reflect its behavior.
- Reorder some items to group the used and allocator flags together
- Renumber them without gaps
@rustbot
Copy link
Collaborator

rustbot commented May 24, 2025

The Miri subtree was changed

cc @rust-lang/miri

@compiler-errors
Copy link
Member

yippee

r? compiler-errors @bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 24, 2025

📌 Commit fa2bb59 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 24, 2025
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 24, 2025
…iler-errors

Cleanup CodegenFnAttrFlags

- Rename `USED` to `USED_COMPILER` to better reflect its behavior.
- Reorder some items to group the used and allocator flags together
- Renumber them without gaps
jhpratt added a commit to jhpratt/rust that referenced this pull request May 24, 2025
…iler-errors

Cleanup CodegenFnAttrFlags

- Rename `USED` to `USED_COMPILER` to better reflect its behavior.
- Reorder some items to group the used and allocator flags together
- Renumber them without gaps
bors added a commit that referenced this pull request May 24, 2025
Rollup of 6 pull requests

Successful merges:

 - #140066 (Stabilize `<[T; N]>::as_mut_slice` as `const`)
 - #141105 (additional edge cases tests for `path.rs` 🧪 )
 - #141487 (Update askama to `0.14.0`)
 - #141498 (Use C-string literals to reduce boilerplate)
 - #141505 (rename internal panicking::try to catch_unwind)
 - #141511 (Cleanup CodegenFnAttrFlags)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7cd749d into rust-lang:master May 25, 2025
6 checks passed
rust-timer added a commit that referenced this pull request May 25, 2025
Rollup merge of #141511 - Noratrieb:codegen-fn-attrs, r=compiler-errors

Cleanup CodegenFnAttrFlags

- Rename `USED` to `USED_COMPILER` to better reflect its behavior.
- Reorder some items to group the used and allocator flags together
- Renumber them without gaps
@rustbot rustbot added this to the 1.89.0 milestone May 25, 2025
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request May 25, 2025
Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#140066 (Stabilize `<[T; N]>::as_mut_slice` as `const`)
 - rust-lang/rust#141105 (additional edge cases tests for `path.rs` 🧪 )
 - rust-lang/rust#141487 (Update askama to `0.14.0`)
 - rust-lang/rust#141498 (Use C-string literals to reduce boilerplate)
 - rust-lang/rust#141505 (rename internal panicking::try to catch_unwind)
 - rust-lang/rust#141511 (Cleanup CodegenFnAttrFlags)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants