Skip to content

Introduce and use specialized //@ ignore-auxiliary for test support files instead of using //@ ignore-test #139967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 18, 2025
+56 −60
Merged

Introduce and use specialized //@ ignore-auxiliary for test support files instead of using //@ ignore-test #139967

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d20f848
compiletest: add specific `//@ ignore-auxiliary` for test support files
jieyouxu Apr 17, 2025
d1178fa
tests: refine disable reason for `tests/debuginfo/drop-locations.rs`
jieyouxu Apr 17, 2025
6bbee33
rustc-dev-guide: document `//@ ignore-auxiliary`
jieyouxu Apr 17, 2025
89cac55
tests: use `//@ ignore-auxiliary` with backlinked primary test file
jieyouxu Apr 17, 2025
6c5a481
tests: remove unused auxiliaries under `tests/ui/directory_ownership/`
jieyouxu Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions tests/ui/directory_ownership/mod_file_not_owning_aux1.rs
View file
Open in desktop
Copy link
Member Author

@jieyouxu jieyouxu Apr 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark: I believe there used to be a test that used these, but somehow that test either got changed, moved or removed, and now these aux files are no longer used. I couldn't find the cause of this through git blame.

Copy link
Member

@wesleywiser wesleywiser Apr 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem to be the commits:

I found these by doing git log -- **/aux_file_name.rs to find the commit which introduced the file and associated test and then I repeated the same thing again with the actual test name to find the commit where it was removed.

This file was deleted.

1 change: 0 additions & 1 deletion tests/ui/directory_ownership/mod_file_not_owning_aux2.rs
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions tests/ui/directory_ownership/mod_file_not_owning_aux3.rs
View file
Open in desktop

This file was deleted.

Loading