Skip to content

fix autodiff compile time regression #136413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 3, 2025
Merged

fix autodiff compile time regression #136413

merged 2 commits into from
Feb 3, 2025

Conversation

ZuseZ4
Copy link
Member

@ZuseZ4 ZuseZ4 commented Feb 2, 2025 •
edited by traviscross
Loading

Tries to fix the regression from #133429

Tracking:

@rustbot
Copy link
Collaborator

rustbot commented Feb 2, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 2, 2025
@ZuseZ4
Copy link
Member Author

ZuseZ4 commented Feb 2, 2025

Well fair enough, if I add r? @oli-obk in the homu-ignore section it will be ignored.

@rustbot rustbot assigned oli-obk and unassigned petrochenkov Feb 2, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@workingjubilee workingjubilee assigned oli-obk and unassigned oli-obk Feb 2, 2025
@workingjubilee
Copy link
Member

derp.

@ZuseZ4 ZuseZ4 force-pushed the fix-autodiff-comptime-regression branch from 7c259f9 to 199ef41 Compare February 2, 2025 01:27
@workingjubilee
Copy link
Member

@bors try

@bors
Copy link
Collaborator

bors commented Feb 2, 2025

⌛ Trying commit 199ef41 with merge 719d8b8...

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 2, 2025
@bors
Auto merge of rust-lang#136413 - EnzymeAD:fix-autodiff-comptime-regre…
719d8b8 
…ssion, r=<try>

test autodiff compile time fixes

Tries to fix the regression from rust-lang#133429
@traviscross traviscross mentioned this pull request Feb 2, 2025
Open
7 tasks
@bors
Copy link
Collaborator

bors commented Feb 2, 2025

☀️ Try build successful - checks-actions
Build commit: 719d8b8 (719d8b829f49aa1a90d25afcf05631f8db213bc4)

@workingjubilee
Copy link
Member

@rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 2, 2025
@lqd
Copy link
Member

lqd commented Feb 2, 2025

@rust-timer build 719d8b8

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (719d8b8): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -30.3% [-30.7%, -29.8%] 4
Improvements ✅
(secondary)		 -30.0% [-31.9%, -28.2%] 2
All ❌✅ (primary) -30.3% [-30.7%, -29.8%] 4

Max RSS (memory usage)

Results (secondary -2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.2% [-2.2%, -2.2%] 1
All ❌✅ (primary) - - 0

Cycles

Results (primary -31.0%, secondary -10.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.4% [2.3%, 5.6%] 3
Improvements ✅
(primary)		 -31.0% [-31.3%, -30.3%] 4
Improvements ✅
(secondary)		 -31.3% [-32.8%, -29.7%] 2
All ❌✅ (primary) -31.0% [-31.3%, -30.3%] 4

Binary size

Results (primary -0.1%, secondary 0.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.0% [0.0%, 0.0%] 3
Regressions ❌
(secondary)		 0.6% [0.6%, 0.6%] 2
Improvements ✅
(primary)		 -0.4% [-0.4%, -0.4%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.1% [-0.4%, 0.0%] 4

Bootstrap: 777.275s -> 777.68s (0.05%)
Artifact size: 328.69 MiB -> 328.71 MiB (0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 2, 2025
@ZuseZ4
Copy link
Member Author

ZuseZ4 commented Feb 2, 2025

Bingo.

@ZuseZ4
Copy link
Member Author

ZuseZ4 commented Feb 2, 2025 •
edited
Loading

We had a 43% primary regression, and here a 30% primary improvement.
143%*0.7=100.1%
Looks like my math lectures weren't completely useless.

ready to merge

@ZuseZ4 ZuseZ4 mentioned this pull request Feb 2, 2025
Merged
@ZuseZ4 ZuseZ4 changed the title test autodiff compile time fixes fix autodiff compile time regression Feb 2, 2025
@oli-obk
Copy link
Contributor

oli-obk commented Feb 2, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 2, 2025

📌 Commit 199ef41 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 2, 2025
@oli-obk oli-obk mentioned this pull request Feb 2, 2025
Merged
@oli-obk
Copy link
Contributor

oli-obk commented Feb 2, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 2, 2025

📌 Commit e47caa2 has been approved by oli-obk

It is now in the queue for this repository.

@jieyouxu
Copy link
Member

jieyouxu commented Feb 3, 2025

@bors p=1 (claws back a perf regression)

@bors
Copy link
Collaborator

bors commented Feb 3, 2025

⌛ Testing commit e47caa2 with merge a5db378...

@bors
Copy link
Collaborator

bors commented Feb 3, 2025

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing a5db378 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 3, 2025
@bors bors merged commit a5db378 into rust-lang:master Feb 3, 2025
7 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Feb 3, 2025
@ZuseZ4 ZuseZ4 deleted the fix-autodiff-comptime-regression branch February 3, 2025 13:55
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a5db378): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -30.3% [-30.6%, -29.7%] 4
Improvements ✅
(secondary)		 -30.1% [-32.0%, -28.2%] 2
All ❌✅ (primary) -30.3% [-30.6%, -29.7%] 4

Max RSS (memory usage)

Results (secondary -3.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.7% [-3.7%, -3.7%] 1
All ❌✅ (primary) - - 0

Cycles

Results (primary -31.1%, secondary -31.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -31.1% [-31.5%, -30.4%] 4
Improvements ✅
(secondary)		 -31.4% [-33.1%, -29.7%] 2
All ❌✅ (primary) -31.1% [-31.5%, -30.4%] 4

Binary size

Results (primary -0.1%, secondary 0.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.0% [0.0%, 0.0%] 3
Regressions ❌
(secondary)		 0.6% [0.6%, 0.6%] 1
Improvements ✅
(primary)		 -0.4% [-0.4%, -0.4%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.1% [-0.4%, 0.0%] 4

Bootstrap: 779.014s -> 777.808s (-0.15%)
Artifact size: 328.74 MiB -> 328.83 MiB (0.03%)

@ZuseZ4 ZuseZ4 added the F-autodiff `#![feature(autodiff)]` label Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

@klensy klensy klensy left review comments

Assignees

@oli-obk oli-obk

Labels
F-autodiff `#![feature(autodiff)]` merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.