rust-mode cleanup. #13432
rust-mode cleanup. #13432
Conversation
* Use `setq-local' instead of (set (make-local-variable ...) value). Provides a version for older Emacsen. * Remove use of `cl.el'. * Use \' in file regexp instead of line end match $. * Use type for defcustom and add parent group.
|
Generally it seems also like a good idea to replace the custom indent/fill code with SMIE. See |
|
Hi @ruediger, thanks for this work; seems alright to me, but I don't know a lot of elisp. (Very sorry that this has sat here for so long!) cc @pnkfelix @nikomatsakis (I believe you're emacs users?) |
|
Oh, btw, @ruediger there are some tests for the emacs mode, I believe you can run them with the shell script adjacent to rust-mode.el. Do they still pass with this patch? (I don't think they're checked by our bots, so we have to resort to manual checks.) |
|
Yes, it passes the tests for me. |
|
Awesome! (Thanks again) |
|
I use emacs for don't really know much about elisp. I'll give the proposed changes a whirl though. (This reminds me, I've been meaning to file another bug about some weird indentation behavior) |
|
(All the changes looked good to me; not sure if emacs-mode has a proper owner...?) |
* Use `setq-local` instead of `(set (make-local-variable 'var) value)`. Provides a version for older Emacsen. * Remove use of `cl.el`. * Use \' in file regexp instead of line end match $. * Use type for `defcustom` and add parent group.
|
I'm willing to volunteer to be the emacs-mode owner. |
Lint comparison to empty slice using `PartialEq` methods changelog: [`comparison_to_empty`]: Also detect comparaisons using `PartialEq` methods Fix rust-lang#13401
setq-localinstead of(set (make-local-variable 'var) value). Provides a version for older Emacsen.cl.el.defcustomand add parent group.