Remove a lit_to_const call

[oli-obk]

We have so many special cases of match expr.kind { Lit() => {}, Unary(Neg, Lit()) => {} }... I'm trying to figure out how to get these all unified, but outright removing some is good, too. So let's try it.

Tho we don't have many const {} blocks in the perf test suite... But I also don't know how common const { 42 } blocks are, I'd expect these to occur mostly from macros (like thread_local!)

[rustbot]

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

Some changes occurred in match checking

cc @Nadrieril

[oli-obk]

@bors try @rust-timer queue

[bors]

⌛ Trying commit fcaaa11 with merge 3170707...

[bors]

☀️ Try build successful - checks-actions
Build commit: 3170707 (3170707dee33eb27efba815f1ec0a0cf786768f1)

[rust-timer]

Finished benchmarking commit (3170707): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 2.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.3%	[2.3%, 2.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 768.023s -> 768.128s (0.01%)
Artifact size: 330.84 MiB -> 330.79 MiB (-0.01%)

[oli-obk]

Jup, as I thought. Undertested, but also 🤷

this makes further lit_to_const work easier, so let's remove it.

[jieyouxu]

Thanks! This simplification makes sense to me. If this turns out perf load-bearing we can revert 🤷

[jieyouxu]

r? jieyouxu
@bors r+ rollup=never (undertested, underexercised in perf suite that's potentially perf-sensitive)

[bors]

📌 Commit 44019ee has been approved by jieyouxu

It is now in the queue for this repository.

[bors]

⌛ Testing commit 44019ee with merge cdb89d6...

[bors]

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing cdb89d6 to master...

[rust-timer]

Finished benchmarking commit (cdb89d6): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.9%, secondary 2.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.9%	[0.9%, 0.9%]	1
Regressions ❌ (secondary)	2.5%	[2.5%, 2.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.9%	[0.9%, 0.9%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 769.879s -> 768.799s (-0.14%)
Artifact size: 330.83 MiB -> 330.84 MiB (0.01%)