-
Notifications
You must be signed in to change notification settings - Fork 13.4k
run-make: add some basic docs about the test suite's setup #126087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
# The `run-make` test suite | ||
|
||
The `run-make` test suite contains tests which are the most flexible out of all | ||
the [rust-lang/rust](https://github.com/rust-lang/rust) test suites. `run-make` | ||
tests can basically contain arbitrary code, and are supported by the | ||
[`run_make_support`] library. | ||
|
||
## Infrastructure | ||
|
||
There are two kinds of run-make tests: | ||
|
||
1. The new `rmake.rs` version: this allows run-make tests to be written in Rust | ||
(with `rmake.rs` as the main test file). | ||
2. The legacy `Makefile` version: this is what run-make tests were written with | ||
before support for `rmake.rs` was introduced. | ||
|
||
The implementation for collecting and building the `rmake.rs` recipes (or | ||
`Makefile`s) are in | ||
[`src/tools/compiletest/src/runtest.rs`](../../src/tools/compiletest/src/runtest.rs), | ||
in `run_rmake_v2_test` and `run_rmake_legacy_test`. | ||
|
||
### Rust-based `run-make` tests: `rmake.rs` | ||
|
||
The setup for the `rmake.rs` version is a 3-stage process: | ||
|
||
1. First, we build the [`run_make_support`] library in bootstrap as a tool lib. | ||
2. Then, we compile the `rmake.rs` "recipe" linking the support library and its | ||
dependencies in, and provide a bunch of env vars. We setup a directory | ||
structure within `build/<target>/test/run-make/` | ||
|
||
``` | ||
<test-name>/ | ||
rmake.exe # recipe binary | ||
rmake_out/ # sources from test sources copied over | ||
``` | ||
|
||
and copy non-`rmake.rs` input support files over to `rmake_out/`. The | ||
support library is made available as an [*extern prelude*][extern_prelude]. | ||
3. Finally, we run the recipe binary and set `rmake_out/` as the working | ||
directory. | ||
|
||
[`run_make_support`]: ../../src/tools/run-make-support | ||
[extern_prelude]: https://doc.rust-lang.org/reference/names/preludes.html#extern-prelude |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.