Skip to content

codegen tests: Tolerate range() qualifications in enum tests #124543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

maurer
Copy link
Contributor

@maurer maurer commented Apr 29, 2024

Current LLVM can infer range bounds on the i8s involved with these tests, and annotates it. Accept these bounds if present.

@rustbot label: +llvm-main

cc @durin42

@rustbot
Copy link
Collaborator

rustbot commented Apr 29, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) labels Apr 29, 2024
Current LLVM can infer range bounds on the i8s involved with these
tests, and annotates it. Accept these bounds if present.
@nikic
Copy link
Contributor

nikic commented Apr 30, 2024

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 30, 2024

📌 Commit 8101884 has been approved by nikic

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 30, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 30, 2024
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#124519 (adapt a codegen test for llvm 19)
 - rust-lang#124524 (Add StaticForeignItem and use it on ForeignItemKind)
 - rust-lang#124540 (Give proof tree visitors the ability to instantiate nested goals directly)
 - rust-lang#124543 (codegen tests: Tolerate `range()` qualifications in enum tests)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d81e444 into rust-lang:master Apr 30, 2024
9 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 30, 2024
Rollup merge of rust-lang#124543 - maurer:llvm-range, r=nikic

codegen tests: Tolerate `range()` qualifications in enum tests

Current LLVM can infer range bounds on the i8s involved with these tests, and annotates it. Accept these bounds if present.

`@rustbot` label: +llvm-main

cc `@durin42`
@rustbot rustbot added this to the 1.80.0 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants