Skip to content

Rollup of 537 pull requests #123329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

TomAFrench and others added 6 commits April 1, 2024 11:43
chore: fix footnotes/links in `platform-support.md`

A missing newline between two references is resulting in some links/footnotes not rendering properly. This PR fixes this.
…ons, r=compiler-errors

Fixup parsing of `rustc_never_type_options` attribute

rust-lang#122843 had a copy paste error, which I did not caught when testing.

r? ``@compiler-errors``
…compiler-errors

Update `ParamEnv` docs

There is now a wealth of information in the dev guide about `ParamEnv` so we should explicitly link to it from the doc comments. I also added a caution against using `ParamEnv` and removed the comment about it being "suitable for type checking" as you should practically never use `ParamEnv::empty` for type checking

r? ``@compiler-errors``
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Apr 1, 2024
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=3

@bors
Copy link
Collaborator

bors commented Apr 1, 2024

📌 Commit 8ab2449 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2024
@matthiaskrgr matthiaskrgr changed the title Rollup of 3 pull requests Rollup of 537 pull requests Apr 1, 2024
@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
    Checking rustc_metadata v0.0.0 (/checkout/compiler/rustc_metadata)
error: unresolved link to `param_env_guide`
    --> compiler/rustc_middle/src/ty/mod.rs:1039:25
     |
1039 | /// [dev guide chapter](param_env_guide) for more information.
     |                         ^^^^^^^^^^^^^^^ no item named `param_env_guide` in scope
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
     = note: `-D rustdoc::broken-intra-doc-links` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(rustdoc::broken_intra_doc_links)]`

@fmease
Copy link
Member

fmease commented Apr 1, 2024

You see, if you keep rolling up so many PRs, it's no wonder that they fail! I would strongly recommend you to limit the number of rolled up PRs to not more than one!

@matthiaskrgr matthiaskrgr deleted the rollup-sekrjk4 branch September 1, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants