Check for trait impl conflicts across crates #12023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So the whole issue was with implementations in other crates? When conflicting implementations are in the same crate we have good errors, and after this patch we indicate which other crate contains impls? |
|
Yes, I think so. |
|
I'm hoping somebody more familiar with the type checker will review. |
|
@brson this looks straightforward to me, do you have any reservations about it? |
|
r=me with a squash |
|
squashed |
bors
added a commit
that referenced
this pull request
Feb 5, 2014
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
internal: more visibility for switch workspaces and its states
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 11, 2024
…ion, r=flip1995 ci: Update to `actions/checkout@v4` from `v3`. This also updates the book's section on CI for the same thing. changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3512