Don't call predicate_must_hold-esque functions during fulfillment in intercrate

[compiler-errors]

Fixes #113415

Given that this only happens in translate_substs, I don't actually think that this is something that you can weaponize, but it's still sketchy regardless.

r? @lcnr

[lcnr]

@bors try @rust-timer queue

r=me after perf

[bors]

⌛ Trying commit 8f178d1 with merge 0e4e5ec50e6a880de58067105fea2c93f1ca56e9...

[bors]

☀️ Try build successful - checks-actions
Build commit: 0e4e5ec50e6a880de58067105fea2c93f1ca56e9 (0e4e5ec50e6a880de58067105fea2c93f1ca56e9)

[bors]

☀️ Try build successful - checks-actions
Build commit: 0e4e5ec50e6a880de58067105fea2c93f1ca56e9 (0e4e5ec50e6a880de58067105fea2c93f1ca56e9)

[rust-timer]

Finished benchmarking commit (0e4e5ec50e6a880de58067105fea2c93f1ca56e9): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.4%	[2.4%, 2.4%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 657.74s -> 658.447s (0.11%)

[compiler-errors]

@bors r=lcnr

[bors]

📌 Commit 8f178d1 has been approved by lcnr

It is now in the queue for this repository.

[bors]

⌛ Testing commit 8f178d1 with merge 0e8e857...

[bors]

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing 0e8e857 to master...

[rust-timer]

Finished benchmarking commit (0e8e857): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.7%, 0.8%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.8%	[0.7%, 0.8%]	2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.2%	[-5.2%, -2.1%]	4
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 657.92s -> 658.666s (0.11%)