[do not merge] CI experiments #112049

Kobzol · 2023-05-28T21:07:18Z

Various CI experiments for try/dist builds.

Kobzol · 2023-05-28T21:07:27Z

bors · 2023-05-28T21:07:35Z

⌛ Trying commit c42e33cf36e728937b9e7d9bbb16c17d0b364e23 with merge c60ecf63ab7a2a0a260b0a8ee02adff4f4dbfe87...

bors · 2023-05-28T22:44:38Z

☀️ Try build successful - checks-actions
Build commit: c60ecf63ab7a2a0a260b0a8ee02adff4f4dbfe87 (c60ecf63ab7a2a0a260b0a8ee02adff4f4dbfe87)

rust-timer · 2023-05-29T03:49:49Z

Finished benchmarking commit (c60ecf63ab7a2a0a260b0a8ee02adff4f4dbfe87): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.3%, 0.3%]	2
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	2
Improvements ✅ (primary)	-0.3%	[-0.3%, -0.3%]	1
Improvements ✅ (secondary)	-0.4%	[-0.7%, -0.2%]	9
All ❌✅ (primary)	0.1%	[-0.3%, 0.3%]	3

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.4%	[3.4%, 3.4%]	1
Regressions ❌ (secondary)	1.8%	[1.8%, 1.8%]	1
Improvements ✅ (primary)	-3.5%	[-3.5%, -3.5%]	1
Improvements ✅ (secondary)	-3.4%	[-3.7%, -3.1%]	2
All ❌✅ (primary)	-0.1%	[-3.5%, 3.4%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.0%	[-2.2%, -1.7%]	2
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 646.44s -> 646.666s (0.03%)

Kobzol · 2023-05-29T06:14:36Z

Looks like removing libcore from the profile set doesn't hurt much. Now I'll try to also completely remove rustc-perf gathering when gathering LLVM PGO profiles.

Looks like after the initial stage 2 build with an instrumented LLVM, there is already 6 GiB of profiles (after benchmarks it's usually 20 GiB). So instrumenting stage 2 build provides a lot of data! I'll try what happens if we delete the profiles.

@bors try @rust-timer queue

bors · 2023-05-29T06:14:48Z

⌛ Trying commit 31c917d813e3461b6babe1220a1ac15fc66eae53 with merge 3004a6cee0725e571674b0efdefcd9b82b1e11d6...

bors · 2023-05-29T08:17:30Z

☀️ Try build successful - checks-actions
Build commit: 3004a6cee0725e571674b0efdefcd9b82b1e11d6 (3004a6cee0725e571674b0efdefcd9b82b1e11d6)

Kobzol · 2023-05-29T08:19:19Z

@bors try

bors · 2023-05-29T08:19:28Z

⌛ Trying commit 042e02535bb5a95c8d6d77fc5954d762b73079e0 with merge ed48ba9307a0a1b523e3519499c3918be2dba056...

rust-timer · 2023-05-29T09:33:21Z

Finished benchmarking commit (3004a6cee0725e571674b0efdefcd9b82b1e11d6): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.2%	[0.3%, 7.3%]	51
Regressions ❌ (secondary)	3.1%	[0.4%, 5.9%]	24
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.2%	[0.3%, 7.3%]	51

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.5%	[2.5%, 2.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.6%	[0.8%, 4.1%]	32
Regressions ❌ (secondary)	2.8%	[1.8%, 3.6%]	12
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.6%	[0.8%, 4.1%]	32

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 642.999s -> 642.878s (-0.02%)

bors · 2023-05-29T10:34:36Z

☀️ Try build successful - checks-actions
Build commit: ed48ba9307a0a1b523e3519499c3918be2dba056 (ed48ba9307a0a1b523e3519499c3918be2dba056)

Kobzol · 2023-05-29T10:56:16Z

@rust-timer build ed48ba9307a0a1b523e3519499c3918be2dba056

rust-timer · 2023-05-29T12:33:22Z

Finished benchmarking commit (ed48ba9307a0a1b523e3519499c3918be2dba056): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.0%	[-2.0%, -0.3%]	33
Improvements ✅ (secondary)	-1.1%	[-1.5%, -0.4%]	12
All ❌✅ (primary)	-1.0%	[-2.0%, -0.3%]	33

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.5%	[2.5%, 2.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.8%	[-2.8%, -2.8%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 642.999s -> 644.35s (0.21%)

[do not merge] CI experiments Various CI experiments for try/dist builds. r? `@ghost` try-job: aarch64-gnu try-job: dist-x86_64-msvc

Kobzol · 2025-05-31T14:43:43Z

@bors2 help

rust-bors · 2025-05-31T14:43:46Z

r+ [p=<priority>] [rollup=<never|iffy|maybe|always>]: Approve this PR. Optionally, you can specify <priority>, <rollup>.
r=<user> [p=<priority>]: Approve this PR on behalf of <user>. Optionally, you can specify a <priority>.
r-: Unapprove this PR
p=<priority>: Set the priority of this PR
delegate=<try|review>: Delegate permissions to the PR author
delegate+: Delegate review permissions to the PR author
delegate-: Remove any previously granted delegation
try [parent=<parent>] [jobs=<jobs>]: Start a try build. Optionally, you can specify a <parent> SHA or a list of <jobs> to run
try cancel: Cancel a running try build
rollup=<never|iffy|maybe|always>: Mark the rollup status of the PR
info: Get information about the current PR including delegation, priority, merge status, and try build status
ping: Check if the bot is alive
help: Print this help message
treeclosed-, treeopen: Open the repository tree for merging
treeclosed=<priority>: Close the tree for PRs with priority less than <priority>

rust-bors · 2025-05-31T14:47:09Z

💔 Test failed

CI ❌

Kobzol · 2025-05-31T15:08:42Z

@bors2 try

rust-bors · 2025-05-31T15:08:46Z

⌛ Trying commit ec31a7f with merge ea42f30…

[do not merge] CI experiments Various CI experiments for try/dist builds. r? `@ghost` try-job: mingw-check

rust-bors · 2025-05-31T15:20:56Z

💔 Test failed

CI ❌

Kobzol · 2025-05-31T16:12:07Z

@bors2 try

rust-bors · 2025-05-31T16:12:10Z

⌛ Trying commit ef53c32 with merge fa92382…

[do not merge] CI experiments Various CI experiments for try/dist builds. r? `@ghost` try-job: mingw-check

rust-bors · 2025-05-31T16:44:52Z

💔 Test failed

CI ❌

Kobzol · 2025-05-31T17:17:24Z

@bors2 try

rust-bors · 2025-05-31T17:17:27Z

⌛ Trying commit ef53c32 with merge 15ad748…

[do not merge] CI experiments Various CI experiments for try/dist builds. r? `@ghost`

rust-bors · 2025-05-31T19:47:06Z

☀️ Try build successful (CI)
Build commit: 15ad748 (15ad748df3071fa8c887879d506395a56b61cf62)

Kobzol · 2025-06-02T06:25:30Z

@bors2 try @rust-timer queue

rust-bors · 2025-06-02T06:25:33Z

⌛ Trying commit 9d2a460 with merge 97ba273…

[do not merge] CI experiments Various CI experiments for try/dist builds. r? `@ghost`

rust-bors · 2025-06-02T09:47:28Z

☀️ Try build successful (CI)
Build commit: 97ba273 (97ba273fa6b06696fc74cd6279568e5c186a854d)

rust-timer · 2025-06-02T11:18:15Z

Finished benchmarking commit (97ba273): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.3%, 0.6%]	25
Regressions ❌ (secondary)	0.5%	[0.5%, 0.7%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.6%	[-1.0%, -0.3%]	7
All ❌✅ (primary)	0.4%	[0.3%, 0.6%]	25

Max RSS (memory usage)

Results (secondary -2.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.0%	[0.7%, 1.4%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.1%	[-8.2%, -0.5%]	16
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -0.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.8%	[0.4%, 1.9%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.9%	[-2.8%, -0.4%]	7
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 775.84s -> 777.406s (0.20%)
Artifact size: 372.26 MiB -> 371.11 MiB (-0.31%)

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 28, 2023

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 28, 2023

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels May 29, 2023

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 29, 2023

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 29, 2023

This comment has been minimized.

Sign in to view

rustbot removed the perf-regression Performance regression. label May 29, 2023

rust-bors bot added a commit that referenced this pull request May 31, 2025

Auto merge of #112049 - Kobzol:pgo-omit-benchmarks, r=<try>

b6ddf63

[do not merge] CI experiments Various CI experiments for try/dist builds. r? `@ghost` try-job: aarch64-gnu try-job: dist-x86_64-msvc

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request May 31, 2025

Auto merge of #112049 - Kobzol:pgo-omit-benchmarks, r=<try>

ea42f30

[do not merge] CI experiments Various CI experiments for try/dist builds. r? `@ghost` try-job: mingw-check

Kobzol force-pushed the pgo-omit-benchmarks branch from ec31a7f to ef53c32 Compare May 31, 2025 16:11

rust-bors bot added a commit that referenced this pull request May 31, 2025

Auto merge of #112049 - Kobzol:pgo-omit-benchmarks, r=<try>

fa92382

[do not merge] CI experiments Various CI experiments for try/dist builds. r? `@ghost` try-job: mingw-check

rust-bors bot added a commit that referenced this pull request May 31, 2025

Auto merge of #112049 - Kobzol:pgo-omit-benchmarks, r=<try>

15ad748

[do not merge] CI experiments Various CI experiments for try/dist builds. r? `@ghost`

Build LLVM with Full LTO

9d2a460

Kobzol force-pushed the pgo-omit-benchmarks branch from ef53c32 to 9d2a460 Compare June 2, 2025 06:24

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Jun 2, 2025

Auto merge of #112049 - Kobzol:pgo-omit-benchmarks, r=<try>

97ba273

[do not merge] CI experiments Various CI experiments for try/dist builds. r? `@ghost`

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 2, 2025

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 2, 2025

[do not merge] CI experiments #112049

Are you sure you want to change the base?

[do not merge] CI experiments #112049

Conversation

Kobzol commented May 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kobzol commented May 28, 2023

Uh oh!

This comment has been minimized.

bors commented May 28, 2023

Uh oh!

bors commented May 28, 2023

Uh oh!

This comment has been minimized.

rust-timer commented May 29, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Uh oh!

Kobzol commented May 29, 2023

Uh oh!

This comment has been minimized.

bors commented May 29, 2023

Uh oh!

bors commented May 29, 2023

Uh oh!

This comment has been minimized.

Kobzol commented May 29, 2023

Uh oh!

bors commented May 29, 2023

Uh oh!

rust-timer commented May 29, 2023

Overall result: ❌ regressions - ACTION NEEDED

Uh oh!

bors commented May 29, 2023

Uh oh!

Kobzol commented May 29, 2023

Uh oh!

This comment has been minimized.

rust-timer commented May 29, 2023

Overall result: ✅ improvements - no action needed

Uh oh!

Kobzol commented May 31, 2025

Uh oh!

rust-bors bot commented May 31, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented May 31, 2025

Uh oh!

Kobzol commented May 31, 2025

Uh oh!

rust-bors bot commented May 31, 2025

Uh oh!

rust-bors bot commented May 31, 2025

Uh oh!

Kobzol commented May 31, 2025

Uh oh!

rust-bors bot commented May 31, 2025

Uh oh!

rust-bors bot commented May 31, 2025

Uh oh!

Kobzol commented May 31, 2025

Uh oh!

rust-bors bot commented May 31, 2025

Uh oh!

rust-bors bot commented May 31, 2025

Uh oh!

Kobzol commented Jun 2, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Jun 2, 2025

Uh oh!

rust-bors bot commented Jun 2, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jun 2, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Uh oh!

Uh oh!

Kobzol commented May 28, 2023 •

edited

Loading