Add missing impl blocks for item reexported from private mod in JSON output

[GuillaumeGomez]

Fixes #102583.

Since we don't inline for the JSON output, the impl blocks from private modules are not present when we generate the output. To go around this limitation, in case the impl block doesn't have #[doc(hidden)] and is implementing a public item, we don't strip it.

cc @fmease @aDotInTheVoid
r? @notriddle

[aDotInTheVoid]

Looks good, just some small nits around the test

[aDotInTheVoid]

Nit: This should be in src/test/rustdoc-json/reexport.rs

[GuillaumeGomez]

👍

[aDotInTheVoid]

Nit: Could you also check that S has an impl block, and the impl block has just the expected method

[GuillaumeGomez]

So, for whatever reason I can't do:

// @has "$.index[*][?(@.kind=='impl' && @.inner.for.inner.name=='S')]"

but this one works:

// @has "$.index[*][?(@.kind=='impl')].inner.for.inner.name" '"S"'

I wanted to use it to use to first count the number of impl blocks for S and then count the number of items in this impl. But since it's not possible, I'll just leave it as is I guess...

[aDotInTheVoid]

// @has "$.index[*][?(@.kind=='impl' && @.inner.for.inner.name=='S')]"

doesn't work due to freestrings/jsonpath#91

The way I to work around this is to add a doc comment to the impl and select on that, eg

pub struct S;

//// impl S
impl S {
    pub fn is_present() {}
}

// @set impl_S = "$.index[*][?(@.docs=='impl S')].id"
// @set is_present = "$.index[*][?(@.name=='is_present')].id"
// @is "$.index[*][?(@.name=='S')].inner.impls[*]" $impl_S
// @is "$.index[*][?(@.docs=='impl S')].inner.items[*]" $is_present

[GuillaumeGomez]

Smart trick! That doesn't allow to see how many impl blocks are implemented on S unfortunately but it's much better than currently. :)

[aDotInTheVoid]

If theirs a second impls on S, then it'll fail because several things match to // @is "$.index[*][?(@.name=='S')].inner.impls[*]" $impl_S, but because this in #[no_core], their are no auto traits.

Similarly, this checks theirs only 1 method in the impl.

[GuillaumeGomez]

Makes sense, thanks for the explanation! Then I guess it's ready for final review. :)

[GuillaumeGomez]

Updated! I'm a bit sad I couldn't extend the test as I wanted but I guess it's enough for now. If you find a way to do it, I'd be very interested!

[GuillaumeGomez]

Updated! Thanks for the suggestion @aDotInTheVoid !

[notriddle]

@bors r+

[bors]

📌 Commit 2345cd3155e481bd39ad36c91a2d190edca099ed has been approved by notriddle

It is now in the queue for this repository.

[bors]

☔ The latest upstream changes (presumably #102233) made this pull request unmergeable. Please resolve the merge conflicts.

[GuillaumeGomez]

@bors r=notriddle rollup

[bors]

📌 Commit 0ef36b8 has been approved by notriddle

It is now in the queue for this repository.