Skip to content

Buildbot failure on stale git lockfile again (index.lock) #7995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bluss opened this issue Jul 23, 2013 · 5 comments
Closed

Buildbot failure on stale git lockfile again (index.lock) #7995

bluss opened this issue Jul 23, 2013 · 5 comments

Comments

@bluss
Copy link
Member

bluss commented Jul 23, 2013

CC @graydon

Same as issue #7939

This PR legitimately failed to build: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt/builds/552

All other builds failed in configure stage on a stale git lockfile

http://buildbot.rust-lang.org/builders/auto-mac-64-nopt/builds/535

@huonw
Copy link
Member

huonw commented Jul 23, 2013

I just shutdown mac4, so at least we won't be doing the make-every-PR-fail thing again.

@huonw
Copy link
Member

huonw commented Jul 23, 2013

And linux4 just did the same thing as last time too: http://buildbot.rust-lang.org/builders/auto-linux-all-opt/builds/556/steps/configure/logs/stdio. (I turned it off.)

@dotdash
Copy link
Contributor

dotdash commented Jul 23, 2013

We should probably try to make buildbot use SIGTERM instead of SIGKILL, that gives the process a chance to cleanup, and git should remove the stale lock file. The interruptSignal parameter allows to choose the signal for a given build step.

interruptSignal
If the command should be interrupted (either by buildmaster or timeout etc.), what signal should be sent to the process, specified by name. By default this is "KILL" (9). Specify "TERM" (15) to give the process a chance to cleanup. This functionality requires a 0.8.6 slave or newer.

http://docs.buildbot.net/latest/manual/cfg-buildsteps.html

@graydon
Copy link
Contributor

graydon commented Jul 25, 2013

We don't have 0.8.6 slaves on those machines. I agree though, what's what we should be doing.

Our Buildbot in general needs an update across the board. It's on a hacked-up version of 0.8.5.

@graydon
Copy link
Contributor

graydon commented Jul 31, 2013

All slaves are upgraded to 0.8.8rc1 now and this this change is made (SIGTERM). Reopen if you see this again.

@graydon graydon closed this as completed Jul 31, 2013
flip1995 pushed a commit to flip1995/rust that referenced this issue Dec 2, 2021
Add `needless_late_init` lint

examples:

```rust
let a;
a = 1;
// to
let a = 1;
```
```rust
let b;
match 3 {
    0 => b = "zero",
    1 => b = "one",
    _ => b = "many",
}
// to
let b = match 3 {
    0 => "zero",
    1 => "one",
    _ => "many",
};
```
```rust
let c;
if true {
    c = 1;
} else {
    c = -1;
}
// to
let c = if true {
    1
} else {
    -1
};
```

changelog: Add [`needless_late_init`]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants