Skip to content

Extend metadata to items, not just crates #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue Jun 14, 2011 · 1 comment
Closed

Extend metadata to items, not just crates #487

brson opened this issue Jun 14, 2011 · 1 comment
Assignees
@brson
Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR)
Milestone
0.1 first support...

Comments

@brson
Copy link
Contributor

brson commented Jun 14, 2011

Crates support attributes through the meta statement. To support conditional compilation, among other things, we want to allow attributes on all items.

Instead of using the meta statement, attributes will be applied using syntaxes like the following

#[foo]
mod bar { }

#[foo(10)]
mod bar { }

#[foo = "bar"]
mod baz { }

Maybe even something like

#[foo = "bar", baz]
mod qux { }

To support applying attributes to crates, attributes can be applied to their containing item by following them with a semicolon:

mod foo {
  #[bar];
}
@ghost ghost assigned brson Jun 14, 2011
brson added a commit that referenced this issue Jun 15, 2011
@brson
rustc: Make room in item_mod for metadata
31116dc 
Issue #487
brson added a commit that referenced this issue Jun 15, 2011
@brson
rustc: Parse module attributes
0eefa5f 
Issue #487
brson added a commit that referenced this issue Jun 15, 2011
@brson
rustc: Introduce an attribute type to the AST
11c5c73 
Right now the only thing that it adds to meta_item is an indication of whether
the attribute was declared inside or outside the item, but I expect it will
become more useful.

Issue #487
brson added a commit that referenced this issue Jun 15, 2011
@brson
rustc: Make room in remaining AST item nodes for attributes
1c9277e 
Issue #487
brson added a commit that referenced this issue Jun 15, 2011
@brson
test: Add tests for multiple outer attributes on items
6c6d7c3 
Issue #487
brson added a commit that referenced this issue Jun 15, 2011
@brson
rustc: Pretty-print outer attributes of items
df6ec4f 
Issue #487
brson added a commit that referenced this issue Jun 15, 2011
@brson
test: Add missing fn test cases to run-pass/item-attributes.rs
95bdedf 
Issue #487
brson added a commit that referenced this issue Jun 15, 2011
@brson
rustc: Support outer attributes on items that are defined as statements
2772a29 
Issue #487
brson added a commit that referenced this issue Jun 15, 2011
@brson
test: Add a compile-fail test for attribute/syntax parsing
14c5900 
I don't currently know how to deal with syntax extensions that appear betweeen
an attribute and an item, so this test captures the error that occurs.

Issue #487
brson added a commit that referenced this issue Jun 16, 2011
@brson
rustc: Parse inner attributes of modules
f3996d3 
Issue #487
brson added a commit that referenced this issue Jun 16, 2011
@brson
rustc: Correctly mark attributes as inner attributes
43cbbab 
Issue #487
brson added a commit that referenced this issue Jun 16, 2011
@brson
rustc: Pretty print module inner attributes
b727d07 
Issue #487
brson added a commit that referenced this issue Jun 16, 2011
@brson
test: Add a test for outer attributes on the first module in a file
99301ff 
Issue #487
brson added a commit that referenced this issue Jun 17, 2011
@brson
rustc: Parse inner items of file-level modules linked from crate files
62939e4 
Issue #487
brson added a commit that referenced this issue Jun 17, 2011
@brson
rustc: Parse attributes in crate files
ffae642 
Issue #487
brson added a commit that referenced this issue Jun 17, 2011
@brson
rustc: Parse crate attributes in standalone .rs files
e83a115 
Issue #487
brson added a commit that referenced this issue Jun 17, 2011
@brson
rustc: Change print_file to print_crate
ffa7c76 
The pretty-printer needs access to the crate attributes in order to reproduce
inner crate attributes in standalone .rs files

Issue #487
brson added a commit that referenced this issue Jun 17, 2011
@brson
rustc: Fix regressed handling of bad attributes
4b8fba5 
Issue #487
brson added a commit that referenced this issue Jun 17, 2011
@brson
Add better error messages for bad attributes in .rc files
6f4326c 
Issue #487
brson added a commit that referenced this issue Jun 17, 2011
@brson
rustc: Remove metadata from the session.
81a187e 
This mechanism was not being used for anything. Issue #487.
brson added a commit that referenced this issue Jun 17, 2011
@brson
rustc: Support both meta tags and attributes for crate metadata
6e6bc50 
This is a transitional patch for converting from 'meta' to attributes.

Issue #487
brson added a commit that referenced this issue Jun 19, 2011
@brson
rustc: Replace 'export meta' with attributes
6002304 
Issue #487
brson added a commit that referenced this issue Jun 19, 2011
@brson
Replace unexported meta tags with attributes
f58de2d 
Issue #487
brson added a commit that referenced this issue Jun 21, 2011
@brson
test: Add a test for distinguishing attributes from extensions
34040be 
Issue #487
brson added a commit that referenced this issue Jun 22, 2011
@brson
rustc: Introduce and parse additional meta_item forms
adc18bb 
Examples: #[test], #[link(name = "vers")]

Issue #487
brson added a commit that referenced this issue Jun 28, 2011
@brson
Write metadata for crate attributes. Issue #487
f53c4f7
brson added a commit that referenced this issue Jun 28, 2011
@brson
Write metadata for more meta_item types. Issue #487
cab73f8
brson added a commit that referenced this issue Jun 28, 2011
@brson
Add some helper functions for attributes. Issue #487
0608e27
brson added a commit that referenced this issue Jun 28, 2011
@brson
Rework how linkage attributes are determined
a83b64d 
The meta items within a crate's link attribute are used in linkage:

 #[link(name = "std",
        vers = "1.0",
        custom = "whatever")];

Name and vers are treated specially, and everything else is hashed together
into the crate meta hash.

Issue #487
brson added a commit that referenced this issue Jun 28, 2011
@brson
Add comments to middle::attr. Issue #487
aecc5e6
brson added a commit that referenced this issue Jun 29, 2011
@brson
Remove the last traces of the distinction between export / local meta…
82a74fc 
… items

Issue #487
brson added a commit that referenced this issue Jun 29, 2011
@brson
Cleanup attribute code. Issue #487
83b7215
brson added a commit that referenced this issue Jun 29, 2011
@brson
Support attaching attributes to modules via the crate file. Issue #487
6832f75
brson added a commit that referenced this issue Jul 1, 2011
@brson
Cleanup attribute code. Issue #487
70a28dc
@brson
Copy link
Contributor Author

brson commented Jul 1, 2011

Closing this. Will open new issues for the remaining work.

@brson brson closed this as completed Jul 1, 2011
keeperofdakeys pushed a commit to keeperofdakeys/rust that referenced this issue Dec 12, 2017
@alexcrichton
Merge pull request rust-lang#487 from alexcrichton/bump
3ae8c85 
Bump to 0.2.19
@XP-Fan XP-Fan mentioned this issue Jun 14, 2021
Closed
ZuseZ4 pushed a commit to EnzymeAD/rust that referenced this issue Mar 7, 2023
@wsmoses
Preserve stack alignment (rust-lang#487)
e26b63a
celinval added a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@celinval @tedinski
Merge rustc into rmc - 2021 week 36 (rust-lang#487)
8c19214 
Conflicts:
    .github/workflows/ci.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brson brson

Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR)
Projects
None yet
Milestone
0.1 first supported public release
Development

No branches or pull requests
1 participant
@brson